Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk
Date	2017-02-08 09:20 +0100
Message-ID	<t8vDP-6i1-9@gated-at.bofh.it> (permalink)
References	<t4jBf-7Fe-3@gated-at.bofh.it> <t8l1L-7If-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 07/02/2017 21:52, Radim Krčmář wrote:
> 2017-01-27 19:34+0100, Paolo Bonzini:
>> As in the SVM patch, the guest physical address is passed by
>> VMX to x86_emulate_instruction already, so mark the GPA as available
>> in vcpu->arch.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
> 
> In line with the SVM patch,
> 
> Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
> 
> Still, I don't see why we need a variable that is touched on every VM
> exit.  Is this a mere shortcut to propagating the gpa_available bit with
> the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()?

Yes, pretty much.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page  walk Radim Krčmář <rkrcmar@redhat.com> - 2017-02-07 22:00 +0100
  Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page  walk Paolo Bonzini <pbonzini@redhat.com> - 2017-02-08 09:20 +0100

csiph-web