Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575594 > unrolled thread

[PATCH] staging: vc04_services: remove unused functions

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: vc04_services: remove unused functions Alexander Alemayhu <alexander@alemayhu.com> - 2017-02-07 13:00 +0100
    Re: [PATCH] staging: vc04_services: remove unused functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-07 13:20 +0100
      Re: [PATCH] staging: vc04_services: remove unused functions Alexander Alemayhu <alexander@alemayhu.com> - 2017-02-07 20:20 +0100
      Re: [PATCH] staging: vc04_services: remove unused functions Eric Anholt <eric@anholt.net> - 2017-02-07 22:20 +0100
        Re: [PATCH] staging: vc04_services: remove unused functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-07 23:30 +0100
          Re: [PATCH] staging: vc04_services: remove unused functions Michael Zoran <mzoran@crowfest.net> - 2017-02-08 02:50 +0100
      Re: [PATCH] staging: vc04_services: remove unused functions Arnd Bergmann <arnd@arndb.de> - 2017-02-08 12:00 +0100
        Re: [PATCH] staging: vc04_services: remove unused functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-10 13:50 +0100

#1575594 — [PATCH] staging: vc04_services: remove unused functions

Looking at the history these calls were introduced in 71bad7f08641
(staging: add bcm2708 vchiq driver, 2013-07-02) and they were not
being used at all.

Discovered using sparse and fixes the following output:

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:816:1: warning: symbol 'vchi_readbuf_uint32' was not declared. Should it be static?
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:827:1: warning: symbol 'vchi_writebuf_uint32' was not declared. Should it be static?
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:841:1: warning: symbol 'vchi_readbuf_uint16' was not declared. Should it be static?
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:852:1: warning: symbol 'vchi_writebuf_uint16' was not declared. Should it be static?

Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>
---
 .../vc04_services/interface/vchiq_arm/vchiq_shim.c | 48 ----------------------
 1 file changed, 48 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 48984abc3854..cd0c332210ca 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -808,54 +808,6 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve
 }
 EXPORT_SYMBOL(vchi_get_peer_version);
 
-/* ----------------------------------------------------------------------
- * read a uint32_t from buffer.
- * network format is defined to be little endian
- * -------------------------------------------------------------------- */
-uint32_t
-vchi_readbuf_uint32(const void *_ptr)
-{
-	const unsigned char *ptr = _ptr;
-	return ptr[0] | (ptr[1] << 8) | (ptr[2] << 16) | (ptr[3] << 24);
-}
-
-/* ----------------------------------------------------------------------
- * write a uint32_t to buffer.
- * network format is defined to be little endian
- * -------------------------------------------------------------------- */
-void
-vchi_writebuf_uint32(void *_ptr, uint32_t value)
-{
-	unsigned char *ptr = _ptr;
-	ptr[0] = (unsigned char)((value >> 0)  & 0xFF);
-	ptr[1] = (unsigned char)((value >> 8)  & 0xFF);
-	ptr[2] = (unsigned char)((value >> 16) & 0xFF);
-	ptr[3] = (unsigned char)((value >> 24) & 0xFF);
-}
-
-/* ----------------------------------------------------------------------
- * read a uint16_t from buffer.
- * network format is defined to be little endian
- * -------------------------------------------------------------------- */
-uint16_t
-vchi_readbuf_uint16(const void *_ptr)
-{
-	const unsigned char *ptr = _ptr;
-	return ptr[0] | (ptr[1] << 8);
-}
-
-/* ----------------------------------------------------------------------
- * write a uint16_t into the buffer.
- * network format is defined to be little endian
- * -------------------------------------------------------------------- */
-void
-vchi_writebuf_uint16(void *_ptr, uint16_t value)
-{
-	unsigned char *ptr = _ptr;
-	ptr[0] = (value >> 0)  & 0xFF;
-	ptr[1] = (value >> 8)  & 0xFF;
-}
-
 /***********************************************************
  * Name: vchi_service_use
  *
-- 
2.11.1

[toc] | [next] | [standalone]

#1575610

There is a bunch of vc04_services that we're still looking to merge in
the near future.  Please hold off deleting these until we are further
along on that.

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1575971

On Tue, Feb 07, 2017 at 03:09:44PM +0300, Dan Carpenter wrote:
> There is a bunch of vc04_services that we're still looking to merge in
> the near future.  Please hold off deleting these until we are further
> along on that.
>
OK.

Thanks.

-- 
Mit freundlichen Grüßen

Alexander Alemayhu

[toc] | [prev] | [next] | [standalone]

#1576066

[Multipart message — attachments visible in raw view] — view raw

Dan Carpenter <dan.carpenter@oracle.com> writes:

> There is a bunch of vc04_services that we're still looking to merge in
> the near future.  Please hold off deleting these until we are further
> along on that.

Checking the downstream tree, these are actually dead.

[toc] | [prev] | [next] | [standalone]

#1576125

On Tue, Feb 07, 2017 at 01:13:34PM -0800, Eric Anholt wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
> 
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future.  Please hold off deleting these until we are further
> > along on that.
> 
> Checking the downstream tree, these are actually dead.

Ahh...  Thanks.  In that case, of course, fine let's remove them.

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1576218

[Multipart message — attachments visible in raw view] — view raw

On Wed, 2017-02-08 at 01:19 +0300, Dan Carpenter wrote:
> On Tue, Feb 07, 2017 at 01:13:34PM -0800, Eric Anholt wrote:
> > Dan Carpenter <dan.carpenter@oracle.com> writes:
> > 
> > > There is a bunch of vc04_services that we're still looking to
> > > merge in
> > > the near future.  Please hold off deleting these until we are
> > > further
> > > along on that.
> > 
> > Checking the downstream tree, these are actually dead.
> 
> Ahh...  Thanks.  In that case, of course, fine let's remove them.
> 
> regards,
> dan carpenter
> 

I made a table awhile ago as to which entry points are being used by
what.  Most of the entry points are indeed only being used by those
other drivers which exist mostly to support a debugging tool called
vcdbg(which I didn't find that useful).

The other drivers are small drivers, but I'm not sure bringing them
here makes much sense either especially since they are mostly to
support that debugging tool.  Which complicates things because probably
half the driver could be otherwise deleted instantly.

I attached a list of driver exports and which drivers are using them.

[toc] | [prev] | [next] | [standalone]

#1576439

On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> There is a bunch of vc04_services that we're still looking to merge in
> the near future.  Please hold off deleting these until we are further
> along on that.
> 

More generally speaking, I'd like to see all the 
-Wmissing-declarations/-Wmissing-prototypes warnings addressed
in the kernel and turn on that warning by default.

If there are parts of vc04_services that are intentionally
left in place but currently unused, adding a declaration in the
header file with a comment should be sufficient to prevent it
from getting deleted or seeing bogus warnings.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1578430

On Wed, Feb 08, 2017 at 11:42:21AM +0100, Arnd Bergmann wrote:
> On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future.  Please hold off deleting these until we are further
> > along on that.
> > 
> 
> More generally speaking, I'd like to see all the 
> -Wmissing-declarations/-Wmissing-prototypes warnings addressed
> in the kernel and turn on that warning by default.
> 
> If there are parts of vc04_services that are intentionally
> left in place but currently unused, adding a declaration in the
> header file with a comment should be sufficient to prevent it
> from getting deleted or seeing bogus warnings.

Yeah.  That's true.  There really isn't a good reason to have these
warnings.

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web