Re: [PATCH] staging: vc04_services: remove unused functions

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: vc04_services: remove unused functions
Date	2017-02-10 13:50 +0100
Message-ID	<t9iOe-3rf-5@gated-at.bofh.it> (permalink)
References	<t8cBc-2ms-5@gated-at.bofh.it> <t8cUy-2IN-19@gated-at.bofh.it> <t8y8G-7Ir-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 08, 2017 at 11:42:21AM +0100, Arnd Bergmann wrote:
> On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future.  Please hold off deleting these until we are further
> > along on that.
> > 
> 
> More generally speaking, I'd like to see all the 
> -Wmissing-declarations/-Wmissing-prototypes warnings addressed
> in the kernel and turn on that warning by default.
> 
> If there are parts of vc04_services that are intentionally
> left in place but currently unused, adding a declaration in the
> header file with a comment should be sufficient to prevent it
> from getting deleted or seeing bogus warnings.

Yeah.  That's true.  There really isn't a good reason to have these
warnings.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: vc04_services: remove unused functions Alexander Alemayhu <alexander@alemayhu.com> - 2017-02-07 13:00 +0100
  Re: [PATCH] staging: vc04_services: remove unused functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-07 13:20 +0100
    Re: [PATCH] staging: vc04_services: remove unused functions Alexander Alemayhu <alexander@alemayhu.com> - 2017-02-07 20:20 +0100
    Re: [PATCH] staging: vc04_services: remove unused functions Eric Anholt <eric@anholt.net> - 2017-02-07 22:20 +0100
      Re: [PATCH] staging: vc04_services: remove unused functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-07 23:30 +0100
        Re: [PATCH] staging: vc04_services: remove unused functions Michael Zoran <mzoran@crowfest.net> - 2017-02-08 02:50 +0100
    Re: [PATCH] staging: vc04_services: remove unused functions Arnd Bergmann <arnd@arndb.de> - 2017-02-08 12:00 +0100
      Re: [PATCH] staging: vc04_services: remove unused functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-02-10 13:50 +0100

csiph-web