Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577329 > unrolled thread

[PATCH v2] mm/zsmalloc: fix comment in zsmalloc

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] mm/zsmalloc: fix comment in zsmalloc Yisheng Xie <xieyisheng1@huawei.com> - 2017-02-09 07:30 +0100
    Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-09 08:10 +0100
      Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc Minchan Kim <minchan@kernel.org> - 2017-02-09 09:20 +0100

#1577329 — [PATCH v2] mm/zsmalloc: fix comment in zsmalloc

The class index and fullness group are not encoded in (first)page->mapping
any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
structure"). Instead, they are store in struct zspage. Just delete this
unneeded comment.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Hanjun Guo <guohanjun@huawei.com>
---
v2:
 * just delete the comment for it is no need anymore, suggested by Sergey.

 mm/zsmalloc.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9cc3c0b..08c1a84 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -268,10 +268,6 @@ struct zs_pool {
 #endif
 };
 
-/*
- * A zspage's class index and fullness group
- * are encoded in its (first)page->mapping
- */
 #define FULLNESS_BITS	2
 #define CLASS_BITS	8
 #define ISOLATED_BITS	3
-- 
1.7.12.4

[toc] | [next] | [standalone]

#1577348

On (02/09/17 14:13), Yisheng Xie wrote:
> The class index and fullness group are not encoded in (first)page->mapping
> any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> structure"). Instead, they are store in struct zspage. Just delete this
> unneeded comment.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Hanjun Guo <guohanjun@huawei.com>
> ---
> v2:
>  * just delete the comment for it is no need anymore, suggested by Sergey.

thanks for the patch.

my "suggestion" was just a side note, nothing more. I'm fine with the
"fix the comment" patch that Andrew has added to mmotm.
we need Minchan's opinion on this, until he speaks out let's have V1
("fix the comment") applied.

	-ss

[toc] | [prev] | [next] | [standalone]

#1577364

On Thu, Feb 09, 2017 at 04:05:43PM +0900, Sergey Senozhatsky wrote:
> On (02/09/17 14:13), Yisheng Xie wrote:
> > The class index and fullness group are not encoded in (first)page->mapping
> > any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> > structure"). Instead, they are store in struct zspage. Just delete this
> > unneeded comment.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: Nitin Gupta <ngupta@vflare.org>
> > Cc: Hanjun Guo <guohanjun@huawei.com>
Acked-by: Minchan Kim <minchan@kernel.org>

> > ---
> > v2:
> >  * just delete the comment for it is no need anymore, suggested by Sergey.
> 
> thanks for the patch.
> 
> my "suggestion" was just a side note, nothing more. I'm fine with the
> "fix the comment" patch that Andrew has added to mmotm.
> we need Minchan's opinion on this, until he speaks out let's have V1
> ("fix the comment") applied.

I agree on Sergey's opinion.

Andrew,
Please drop previous patch and replace it with this.

Thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web