Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1577348

Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc

Show all headers | View raw

On (02/09/17 14:13), Yisheng Xie wrote:
> The class index and fullness group are not encoded in (first)page->mapping
> any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> structure"). Instead, they are store in struct zspage. Just delete this
> unneeded comment.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Hanjun Guo <guohanjun@huawei.com>
> ---
> v2:
>  * just delete the comment for it is no need anymore, suggested by Sergey.

thanks for the patch.

my "suggestion" was just a side note, nothing more. I'm fine with the
"fix the comment" patch that Andrew has added to mmotm.
we need Minchan's opinion on this, until he speaks out let's have V1
("fix the comment") applied.

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] mm/zsmalloc: fix comment in zsmalloc Yisheng Xie <xieyisheng1@huawei.com> - 2017-02-09 07:30 +0100
  Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-09 08:10 +0100
    Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc Minchan Kim <minchan@kernel.org> - 2017-02-09 09:20 +0100

csiph-web