Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1574424 > unrolled thread

[PATCH 0/2] kconfig/mconf: propagate jumping function in search result view

Started bychangbin.du@intel.com
First post2017-02-06 08:50 +0100
Last post2017-02-08 09:10 +0100
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du@intel.com - 2017-02-06 08:50 +0100
    [PATCH 2/2] Documentation/kconfig: add search jump feature description changbin.du@intel.com - 2017-02-06 08:50 +0100
      Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description Jim Davis <jim.epost@gmail.com> - 2017-02-06 15:50 +0100
        Re: [PATCH 2/2] Documentation/kconfig: add search jump feature  description "Du, Changbin" <changbin.du@intel.com> - 2017-02-07 04:10 +0100
    [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du@intel.com - 2017-02-08 04:20 +0100
      [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du@intel.com - 2017-02-08 04:20 +0100
        Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox Jani Nikula <jani.nikula@linux.intel.com> - 2017-02-08 09:10 +0100

#1574424 — [PATCH 0/2] kconfig/mconf: propagate jumping function in search result view

Fromchangbin.du@intel.com
Date2017-02-06 08:50 +0100
Subject[PATCH 0/2] kconfig/mconf: propagate jumping function in search result view
Message-ID<t7MdH-1Vy-3@gated-at.bofh.it>
From: Changbin Du <changbin.du@intel.com>

While I am searching something in menuconfig, I hope if I can jump to interested
items directly. I even try to add this feature. When I check the code just found 
it has already been there but not documented. So why let more developers know it?

Changbin Du (2):
  kconfig/mconf: add jumping tip in title of search result textbox
  Documentation/kconfig: add search jump feature description

 Documentation/kbuild/kconfig.txt | 4 ++++
 scripts/kconfig/mconf.c          | 8 ++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1574426 — [PATCH 2/2] Documentation/kconfig: add search jump feature description

Fromchangbin.du@intel.com
Date2017-02-06 08:50 +0100
Subject[PATCH 2/2] Documentation/kconfig: add search jump feature description
Message-ID<t7MdI-1Vy-17@gated-at.bofh.it>
In reply to#1574424
From: Changbin Du <changbin.du@intel.com>

Kernel menuconfig support direct jumping function from the search
result. This is a very convenient feature but not documented. So
add a short description to the kconfig documentation to let more
developer know it.

Signed-off-by: Changbin Du <changbin.du@intel.com>
---
 Documentation/kbuild/kconfig.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
index bbc99c0..9916318 100644
--- a/Documentation/kbuild/kconfig.txt
+++ b/Documentation/kbuild/kconfig.txt
@@ -178,6 +178,10 @@ Searching in menuconfig:
 	first (and in alphabetical order), then come all other symbols,
 	sorted in alphabetical order.
 
+	In the search result textbox, each symbol has a jump number on
+	left side if the symbol is jumpable. You can type the nubmer
+	to jump to target menu to configurate that symbol.
+
 ______________________________________________________________________
 User interface options for 'menuconfig'
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1574862 — Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description

FromJim Davis <jim.epost@gmail.com>
Date2017-02-06 15:50 +0100
SubjectRe: [PATCH 2/2] Documentation/kconfig: add search jump feature description
Message-ID<t7SMb-6cu-39@gated-at.bofh.it>
In reply to#1574426
On Mon, Feb 6, 2017 at 12:46 AM,  <changbin.du@intel.com> wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Kernel menuconfig support direct jumping function from the search
> result. This is a very convenient feature but not documented. So
> add a short description to the kconfig documentation to let more
> developer know it.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
>  Documentation/kbuild/kconfig.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
> index bbc99c0..9916318 100644
> --- a/Documentation/kbuild/kconfig.txt
> +++ b/Documentation/kbuild/kconfig.txt
> @@ -178,6 +178,10 @@ Searching in menuconfig:
>         first (and in alphabetical order), then come all other symbols,
>         sorted in alphabetical order.
>
> +       In the search result textbox, each symbol has a jump number on
> +       left side if the symbol is jumpable. You can type the nubmer

number  ("jumpable" reads a bit oddly, but it is understandable.)

> +       to jump to target menu to configurate that symbol.

configure?

-- 
Jim

[toc] | [prev] | [next] | [standalone]

#1575345 — Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description

From"Du, Changbin" <changbin.du@intel.com>
Date2017-02-07 04:10 +0100
SubjectRe: [PATCH 2/2] Documentation/kconfig: add search jump feature description
Message-ID<t84ki-5rm-15@gated-at.bofh.it>
In reply to#1574862

[Multipart message — attachments visible in raw view] — view raw

On Mon, Feb 06, 2017 at 07:42:11AM -0700, Jim Davis wrote:
> On Mon, Feb 6, 2017 at 12:46 AM,  <changbin.du@intel.com> wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > Kernel menuconfig support direct jumping function from the search
> > result. This is a very convenient feature but not documented. So
> > add a short description to the kconfig documentation to let more
> > developer know it.
> >
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > ---
> >  Documentation/kbuild/kconfig.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
> > index bbc99c0..9916318 100644
> > --- a/Documentation/kbuild/kconfig.txt
> > +++ b/Documentation/kbuild/kconfig.txt
> > @@ -178,6 +178,10 @@ Searching in menuconfig:
> >         first (and in alphabetical order), then come all other symbols,
> >         sorted in alphabetical order.
> >
> > +       In the search result textbox, each symbol has a jump number on
> > +       left side if the symbol is jumpable. You can type the nubmer
> 
> number  ("jumpable" reads a bit oddly, but it is understandable.)
> 
How about 'if the symbol is visible'?

> > +       to jump to target menu to configurate that symbol.
> 
> configure?
>
Thanks, I will correct them.

> -- 
> Jim

-- 
Thanks,
Changbin

[toc] | [prev] | [next] | [standalone]

#1576258 — [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view

Fromchangbin.du@intel.com
Date2017-02-08 04:20 +0100
Subject[PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view
Message-ID<t8qXw-3aG-11@gated-at.bofh.it>
In reply to#1574424
From: Changbin Du <changbin.du@intel.com>

While I am searching something in menuconfig, I hope if I can jump to interested
items directly. I even try to add this feature. When I check the code just found 
it has already been there but not documented. So why let more developers know it?

v2: correct spell (Jim)
   
Changbin Du (2):
  kconfig/mconf: add jumping tip in title of search result textbox
  Documentation/kconfig: add search jump feature description

 Documentation/kbuild/kconfig.txt | 4 ++++
 scripts/kconfig/mconf.c          | 8 ++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1576260 — [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox

Fromchangbin.du@intel.com
Date2017-02-08 04:20 +0100
Subject[PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Message-ID<t8qXw-3aG-15@gated-at.bofh.it>
In reply to#1576258
From: Changbin Du <changbin.du@intel.com>

Prompt user how to quickly jump to the item he/she is interested in.

Signed-off-by: Changbin Du <changbin.du@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>
---
 scripts/kconfig/mconf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
index 315ce2c..23d5681 100644
--- a/scripts/kconfig/mconf.c
+++ b/scripts/kconfig/mconf.c
@@ -443,10 +443,10 @@ static void search_conf(void)
 
 		res = get_relations_str(sym_arr, &head);
 		set_subtitle();
-		dres = show_textbox_ext(_("Search Results"), (char *)
-					str_get(&res), 0, 0, keys, &vscroll,
-					&hscroll, &update_text, (void *)
-					&data);
+		dres = show_textbox_ext(
+				_("Search Results (type the number to jump)"),
+				(char *)str_get(&res), 0, 0, keys, &vscroll,
+				&hscroll, &update_text, (void *)&data);
 		again = false;
 		for (i = 0; i < JUMP_NB && keys[i]; i++)
 			if (dres == keys[i]) {
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1576322 — Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox

FromJani Nikula <jani.nikula@linux.intel.com>
Date2017-02-08 09:10 +0100
SubjectRe: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Message-ID<t8vu9-6eo-7@gated-at.bofh.it>
In reply to#1576260
On Wed, 08 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>

This is assuming too much... but I looked at it now, and it looks good
to me.

Thanks,
Jani.

> ---
>  scripts/kconfig/mconf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>  
>  		res = get_relations_str(sym_arr, &head);
>  		set_subtitle();
> -		dres = show_textbox_ext(_("Search Results"), (char *)
> -					str_get(&res), 0, 0, keys, &vscroll,
> -					&hscroll, &update_text, (void *)
> -					&data);
> +		dres = show_textbox_ext(
> +				_("Search Results (type the number to jump)"),
> +				(char *)str_get(&res), 0, 0, keys, &vscroll,
> +				&hscroll, &update_text, (void *)&data);
>  		again = false;
>  		for (i = 0; i < JUMP_NB && keys[i]; i++)
>  			if (dres == keys[i]) {

-- 
Jani Nikula, Intel Open Source Technology Center

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web