Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox

From	Jani Nikula <jani.nikula@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox
Date	2017-02-08 09:10 +0100
Message-ID	<t8vu9-6eo-7@gated-at.bofh.it> (permalink)
References	<t8qXw-3aG-11@gated-at.bofh.it> <t8qXw-3aG-15@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, 08 Feb 2017, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> Prompt user how to quickly jump to the item he/she is interested in.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@linux.intel.com>

This is assuming too much... but I looked at it now, and it looks good
to me.

Thanks,
Jani.

> ---
>  scripts/kconfig/mconf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 315ce2c..23d5681 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -443,10 +443,10 @@ static void search_conf(void)
>  
>  		res = get_relations_str(sym_arr, &head);
>  		set_subtitle();
> -		dres = show_textbox_ext(_("Search Results"), (char *)
> -					str_get(&res), 0, 0, keys, &vscroll,
> -					&hscroll, &update_text, (void *)
> -					&data);
> +		dres = show_textbox_ext(
> +				_("Search Results (type the number to jump)"),
> +				(char *)str_get(&res), 0, 0, keys, &vscroll,
> +				&hscroll, &update_text, (void *)&data);
>  		again = false;
>  		for (i = 0; i < JUMP_NB && keys[i]; i++)
>  			if (dres == keys[i]) {

-- 
Jani Nikula, Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du@intel.com - 2017-02-06 08:50 +0100
  [PATCH 2/2] Documentation/kconfig: add search jump feature description changbin.du@intel.com - 2017-02-06 08:50 +0100
    Re: [PATCH 2/2] Documentation/kconfig: add search jump feature description Jim Davis <jim.epost@gmail.com> - 2017-02-06 15:50 +0100
      Re: [PATCH 2/2] Documentation/kconfig: add search jump feature  description "Du, Changbin" <changbin.du@intel.com> - 2017-02-07 04:10 +0100
  [PATCH v2 0/2] kconfig/mconf: propagate jumping function in search result view changbin.du@intel.com - 2017-02-08 04:20 +0100
    [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox changbin.du@intel.com - 2017-02-08 04:20 +0100
      Re: [PATCH v2 1/2] kconfig/mconf: add jumping tip in title of search result textbox Jani Nikula <jani.nikula@linux.intel.com> - 2017-02-08 09:10 +0100

csiph-web