Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1571993 > unrolled thread
| Started by | Tyler Baicar <tbaicar@codeaurora.org> |
|---|---|
| First post | 2017-02-01 22:40 +0100 |
| Last post | 2017-02-07 13:10 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] arm64: kconfig: allow support for memory failure handling Tyler Baicar <tbaicar@codeaurora.org> - 2017-02-01 22:40 +0100
Re: [PATCH] arm64: kconfig: allow support for memory failure handling Punit Agrawal <punit.agrawal@arm.com> - 2017-02-03 17:30 +0100
Re: [PATCH] arm64: kconfig: allow support for memory failure handling "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-02-06 23:30 +0100
Re: [PATCH] arm64: kconfig: allow support for memory failure handling Punit Agrawal <punit.agrawal@arm.com> - 2017-02-07 13:10 +0100
| From | Tyler Baicar <tbaicar@codeaurora.org> |
|---|---|
| Date | 2017-02-01 22:40 +0100 |
| Subject | [PATCH] arm64: kconfig: allow support for memory failure handling |
| Message-ID | <t6aNb-37z-7@gated-at.bofh.it> |
From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org> If ACPI_APEI and MEMORY_FAILURE is configured, select ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery when such memory failure is reported through ACPI APEI. APEI (ACPI Platform Error Interfaces) provides a means for the platform to convey error information to the kernel. Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support memory failure recovery attempt. Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> --- arch/arm64/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index f92778d..4cd12a0 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -15,6 +15,8 @@ config ARM64 select ARCH_HAS_SG_CHAIN select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST select ARCH_USE_CMPXCHG_LOCKREF + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE + select ARCH_SUPPORTS_MEMORY_FAILURE select ARCH_SUPPORTS_ATOMIC_RMW select ARCH_SUPPORTS_NUMA_BALANCING select ARCH_WANT_COMPAT_IPC_PARSE_VERSION -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [next] | [standalone]
| From | Punit Agrawal <punit.agrawal@arm.com> |
|---|---|
| Date | 2017-02-03 17:30 +0100 |
| Message-ID | <t6OUi-442-17@gated-at.bofh.it> |
| In reply to | #1571993 |
Tyler Baicar <tbaicar@codeaurora.org> writes: > From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org> > > If ACPI_APEI and MEMORY_FAILURE is configured, select > ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery > when such memory failure is reported through ACPI APEI. APEI > (ACPI Platform Error Interfaces) provides a means for the > platform to convey error information to the kernel. > > Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support > memory failure recovery attempt. > > Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org> > Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> > --- > arch/arm64/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index f92778d..4cd12a0 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -15,6 +15,8 @@ config ARM64 > select ARCH_HAS_SG_CHAIN > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > select ARCH_USE_CMPXCHG_LOCKREF > + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE > + select ARCH_SUPPORTS_MEMORY_FAILURE Although enabling support for memory failure handling makes sense in the architecture config, it feels out of place to select ACPI_APEI_MEMORY_FAILURE here. Maybe key it off of CONFIG_APEI? Thanks, Punit > select ARCH_SUPPORTS_ATOMIC_RMW > select ARCH_SUPPORTS_NUMA_BALANCING > select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
[toc] | [prev] | [next] | [standalone]
| From | "Baicar, Tyler" <tbaicar@codeaurora.org> |
|---|---|
| Date | 2017-02-06 23:30 +0100 |
| Message-ID | <t7ZXj-2yL-7@gated-at.bofh.it> |
| In reply to | #1573241 |
Hello Punit,
On 2/3/2017 9:27 AM, Punit Agrawal wrote:
> Tyler Baicar <tbaicar@codeaurora.org> writes:
>
>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>>
>> If ACPI_APEI and MEMORY_FAILURE is configured, select
>> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery
>> when such memory failure is reported through ACPI APEI. APEI
>> (ACPI Platform Error Interfaces) provides a means for the
>> platform to convey error information to the kernel.
>>
>> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support
>> memory failure recovery attempt.
>>
>> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
>> ---
>> arch/arm64/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index f92778d..4cd12a0 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -15,6 +15,8 @@ config ARM64
>> select ARCH_HAS_SG_CHAIN
>> select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>> select ARCH_USE_CMPXCHG_LOCKREF
>> + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE
>> + select ARCH_SUPPORTS_MEMORY_FAILURE
> Although enabling support for memory failure handling makes sense in the
> architecture config, it feels out of place to select
> ACPI_APEI_MEMORY_FAILURE here.
>
> Maybe key it off of CONFIG_APEI?
Yes, I can move it there.
config ACPI_APEI
bool "ACPI Platform Error Interface (APEI)"
select MISC_FILESYSTEMS
select PSTORE
select UEFI_CPER
+ select ACPI_APEI_MEMORY_FAILURE if MEMORY_FAILURE
depends on HAVE_ACPI_APEI
The ARCH_SUPPORTS_MEMORY_FAILURE should remain in arch/arm64/Kconfig
though, correct?
Thanks,
Tyler
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
[toc] | [prev] | [next] | [standalone]
| From | Punit Agrawal <punit.agrawal@arm.com> |
|---|---|
| Date | 2017-02-07 13:10 +0100 |
| Message-ID | <t8cKS-2F9-23@gated-at.bofh.it> |
| In reply to | #1575208 |
"Baicar, Tyler" <tbaicar@codeaurora.org> writes: > Hello Punit, > > > On 2/3/2017 9:27 AM, Punit Agrawal wrote: >> Tyler Baicar <tbaicar@codeaurora.org> writes: >> >>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org> >>> >>> If ACPI_APEI and MEMORY_FAILURE is configured, select >>> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery >>> when such memory failure is reported through ACPI APEI. APEI >>> (ACPI Platform Error Interfaces) provides a means for the >>> platform to convey error information to the kernel. >>> >>> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support >>> memory failure recovery attempt. >>> >>> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org> >>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> >>> --- >>> arch/arm64/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index f92778d..4cd12a0 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -15,6 +15,8 @@ config ARM64 >>> select ARCH_HAS_SG_CHAIN >>> select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST >>> select ARCH_USE_CMPXCHG_LOCKREF >>> + select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE >>> + select ARCH_SUPPORTS_MEMORY_FAILURE >> Although enabling support for memory failure handling makes sense in the >> architecture config, it feels out of place to select >> ACPI_APEI_MEMORY_FAILURE here. >> >> Maybe key it off of CONFIG_APEI? > Yes, I can move it there. > > config ACPI_APEI > bool "ACPI Platform Error Interface (APEI)" > select MISC_FILESYSTEMS > select PSTORE > select UEFI_CPER > + select ACPI_APEI_MEMORY_FAILURE if MEMORY_FAILURE > depends on HAVE_ACPI_APEI > That's what I was suggesting - we'll see what the ACPI maintainers think of the change. > The ARCH_SUPPORTS_MEMORY_FAILURE should remain in arch/arm64/Kconfig > though, correct? Yes, that's right - as that's a feature the architecture is advertising support for, it should stay in the arm64 Kconfig, > > Thanks, > Tyler
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web