Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1575208

Re: [PATCH] arm64: kconfig: allow support for memory failure handling

Show all headers | View raw

Hello Punit,


On 2/3/2017 9:27 AM, Punit Agrawal wrote:
> Tyler Baicar <tbaicar@codeaurora.org> writes:
>
>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>>
>> If ACPI_APEI and MEMORY_FAILURE is configured, select
>> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery
>> when such memory failure is reported through ACPI APEI. APEI
>> (ACPI Platform Error Interfaces) provides a means for the
>> platform to convey error information to the kernel.
>>
>> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support
>> memory failure recovery attempt.
>>
>> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
>> ---
>>   arch/arm64/Kconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index f92778d..4cd12a0 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -15,6 +15,8 @@ config ARM64
>>   	select ARCH_HAS_SG_CHAIN
>>   	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>>   	select ARCH_USE_CMPXCHG_LOCKREF
>> +	select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE
>> +	select ARCH_SUPPORTS_MEMORY_FAILURE
> Although enabling support for memory failure handling makes sense in the
> architecture config, it feels out of place to select
> ACPI_APEI_MEMORY_FAILURE here.
>
> Maybe key it off of CONFIG_APEI?
Yes, I can move it there.

config ACPI_APEI
         bool "ACPI Platform Error Interface (APEI)"
         select MISC_FILESYSTEMS
         select PSTORE
         select UEFI_CPER
+        select ACPI_APEI_MEMORY_FAILURE if MEMORY_FAILURE
         depends on HAVE_ACPI_APEI

The ARCH_SUPPORTS_MEMORY_FAILURE should remain in arch/arm64/Kconfig 
though, correct?

Thanks,
Tyler

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: kconfig: allow support for memory failure handling Tyler Baicar <tbaicar@codeaurora.org> - 2017-02-01 22:40 +0100
  Re: [PATCH] arm64: kconfig: allow support for memory failure handling Punit Agrawal <punit.agrawal@arm.com> - 2017-02-03 17:30 +0100
    Re: [PATCH] arm64: kconfig: allow support for memory failure handling "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-02-06 23:30 +0100
      Re: [PATCH] arm64: kconfig: allow support for memory failure handling Punit Agrawal <punit.agrawal@arm.com> - 2017-02-07 13:10 +0100

csiph-web