Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1574503 > unrolled thread
| Started by | Byungchul Park <byungchul.park@lge.com> |
|---|---|
| First post | 2017-02-06 10:50 +0100 |
| Last post | 2017-02-06 10:50 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] lockdep: Fix wrong condition to print bug msgs for MAX_LOCKDEP_CHAIN_HLOCKS Byungchul Park <byungchul.park@lge.com> - 2017-02-06 10:50 +0100
| From | Byungchul Park <byungchul.park@lge.com> |
|---|---|
| Date | 2017-02-06 10:50 +0100 |
| Subject | Re: [PATCH] lockdep: Fix wrong condition to print bug msgs for MAX_LOCKDEP_CHAIN_HLOCKS |
| Message-ID | <t7O5P-3el-3@gated-at.bofh.it> |
On Fri, Jan 13, 2017 at 11:42:04AM +0900, Byungchul Park wrote:
> Bug messages and stack dump for MAX_LOCKDEP_CHAIN_HLOCKS should be
> printed only at the first time.
Could you tell me what you think? Am I wrong?
>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
> kernel/locking/lockdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index f37156f..a143eb4 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2166,7 +2166,7 @@ static inline int add_chain_cache(struct task_struct *curr,
> * Important for check_no_collision().
> */
> if (unlikely(nr_chain_hlocks > MAX_LOCKDEP_CHAIN_HLOCKS)) {
> - if (debug_locks_off_graph_unlock())
> + if (!debug_locks_off_graph_unlock())
> return 0;
>
> print_lockdep_off("BUG: MAX_LOCKDEP_CHAIN_HLOCKS too low!");
> --
> 1.9.1
Back to top | Article view | linux.kernel
csiph-web