Re: [PATCH] lockdep: Fix wrong condition to print bug msgs for MAX_LOCKDEP_CHAIN_HLOCKS

From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lockdep: Fix wrong condition to print bug msgs for MAX_LOCKDEP_CHAIN_HLOCKS
Date	2017-02-06 10:50 +0100
Message-ID	<t7O5P-3el-3@gated-at.bofh.it> (permalink)
References	<sZ0fT-3DU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 13, 2017 at 11:42:04AM +0900, Byungchul Park wrote:
> Bug messages and stack dump for MAX_LOCKDEP_CHAIN_HLOCKS should be
> printed only at the first time.

Could you tell me what you think? Am I wrong?

> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  kernel/locking/lockdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index f37156f..a143eb4 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2166,7 +2166,7 @@ static inline int add_chain_cache(struct task_struct *curr,
>  	 * Important for check_no_collision().
>  	 */
>  	if (unlikely(nr_chain_hlocks > MAX_LOCKDEP_CHAIN_HLOCKS)) {
> -		if (debug_locks_off_graph_unlock())
> +		if (!debug_locks_off_graph_unlock())
>  			return 0;
>  
>  		print_lockdep_off("BUG: MAX_LOCKDEP_CHAIN_HLOCKS too low!");
> -- 
> 1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] lockdep: Fix wrong condition to print bug msgs for  MAX_LOCKDEP_CHAIN_HLOCKS Byungchul Park <byungchul.park@lge.com> - 2017-02-06 10:50 +0100

csiph-web