Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1574290 > unrolled thread
| Started by | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| First post | 2017-02-05 23:10 +0100 |
| Last post | 2017-02-08 14:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] tpm xen: drop unneeded chip variable Julia Lawall <Julia.Lawall@lip6.fr> - 2017-02-05 23:10 +0100
Re: [PATCH] tpm xen: drop unneeded chip variable Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-08 14:10 +0100
| From | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| Date | 2017-02-05 23:10 +0100 |
| Subject | [PATCH] tpm xen: drop unneeded chip variable |
| Message-ID | <t7Daq-4IR-15@gated-at.bofh.it> |
The call that used chip was dropped in 1f0f30e404b3. Drop the
leftover declaration and initialization.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/char/tpm/xen-tpmfront.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 5aaa268..656e8af 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -289,7 +289,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
const struct xenbus_device_id *id)
{
struct tpm_private *priv;
- struct tpm_chip *chip;
int rv;
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
@@ -306,7 +305,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
rv = setup_ring(dev, priv);
if (rv) {
- chip = dev_get_drvdata(&dev->dev);
ring_free(priv);
return rv;
}
[toc] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2017-02-08 14:10 +0100 |
| Message-ID | <t8Aau-Kl-27@gated-at.bofh.it> |
| In reply to | #1574290 |
On Sun, Feb 05, 2017 at 10:39:37PM +0100, Julia Lawall wrote:
> The call that used chip was dropped in 1f0f30e404b3. Drop the
> leftover declaration and initialization.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
>
> ---
> drivers/char/tpm/xen-tpmfront.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 5aaa268..656e8af 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -289,7 +289,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
> const struct xenbus_device_id *id)
> {
> struct tpm_private *priv;
> - struct tpm_chip *chip;
> int rv;
>
> priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> @@ -306,7 +305,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>
> rv = setup_ring(dev, priv);
> if (rv) {
> - chip = dev_get_drvdata(&dev->dev);
> ring_free(priv);
> return rv;
> }
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web