Re: [PATCH] tpm xen: drop unneeded chip variable

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm xen: drop unneeded chip variable
Date	2017-02-08 14:10 +0100
Message-ID	<t8Aau-Kl-27@gated-at.bofh.it> (permalink)
References	<t7Daq-4IR-15@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sun, Feb 05, 2017 at 10:39:37PM +0100, Julia Lawall wrote:
> The call that used chip was dropped in 1f0f30e404b3.  Drop the
> leftover declaration and initialization.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> 
> ---
>  drivers/char/tpm/xen-tpmfront.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 5aaa268..656e8af 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -289,7 +289,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>  		const struct xenbus_device_id *id)
>  {
>  	struct tpm_private *priv;
> -	struct tpm_chip *chip;
>  	int rv;
>  
>  	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> @@ -306,7 +305,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>  
>  	rv = setup_ring(dev, priv);
>  	if (rv) {
> -		chip = dev_get_drvdata(&dev->dev);
>  		ring_free(priv);
>  		return rv;
>  	}
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm xen: drop unneeded chip variable Julia Lawall <Julia.Lawall@lip6.fr> - 2017-02-05 23:10 +0100
  Re: [PATCH] tpm xen: drop unneeded chip variable Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-02-08 14:10 +0100

csiph-web