Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572436 > unrolled thread

[PATCH] reset: make zx2967 explicitly non-modular

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] reset: make zx2967 explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-02-02 16:00 +0100
    Re: [PATCH] reset: make zx2967 explicitly non-modular Philipp Zabel <p.zabel@pengutronix.de> - 2017-02-02 16:40 +0100

#1572436 — [PATCH] reset: make zx2967 explicitly non-modular

The Kconfig currently controlling compilation of this code is:

   config RESET_ZX2967
          bool "ZTE ZX2967 Reset Driver

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.

Since builtin_platform_driver() was already in use, the init ordering
remains unchanged with this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

We don't replace module.h with init.h since the file does not appear
to use __init prefix anywhere.

Cc: Jun Nie <jun.nie@linaro.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/reset/reset-zx2967.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/reset/reset-zx2967.c b/drivers/reset/reset-zx2967.c
index 5d821513aa3e..4dabb9ec4841 100644
--- a/drivers/reset/reset-zx2967.c
+++ b/drivers/reset/reset-zx2967.c
@@ -8,7 +8,6 @@
  * License terms: GNU General Public License (GPL) version 2
  */
 
-#include <linux/module.h>
 #include <linux/of_address.h>
 #include <linux/platform_device.h>
 #include <linux/reset-controller.h>
@@ -89,7 +88,6 @@ static const struct of_device_id zx2967_reset_dt_ids[] = {
 	 { .compatible = "zte,zx296718-reset", },
 	 {},
 };
-MODULE_DEVICE_TABLE(of, zx2967_reset_dt_ids);
 
 static struct platform_driver zx2967_reset_driver = {
 	.probe	= zx2967_reset_probe,
@@ -98,9 +96,4 @@ static struct platform_driver zx2967_reset_driver = {
 		.of_match_table	= zx2967_reset_dt_ids,
 	},
 };
-
 builtin_platform_driver(zx2967_reset_driver);
-
-MODULE_AUTHOR("Baoyou Xie <baoyou.xie@linaro.org>");
-MODULE_DESCRIPTION("ZTE zx2967 Reset Controller Driver");
-MODULE_LICENSE("GPL");
-- 
2.11.0

[toc] | [next] | [standalone]

#1572471

On Thu, 2017-02-02 at 09:52 -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
>    config RESET_ZX2967
>           bool "ZTE ZX2967 Reset Driver
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since builtin_platform_driver() was already in use, the init ordering
> remains unchanged with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> We don't replace module.h with init.h since the file does not appear
> to use __init prefix anywhere.
> 
> Cc: Jun Nie <jun.nie@linaro.org>
> Cc: Baoyou Xie <baoyou.xie@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Thank you, applied with Baoyou's Reviewed-by.

regards
Philipp

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web