Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572471

Re: [PATCH] reset: make zx2967 explicitly non-modular

Show all headers | View raw

On Thu, 2017-02-02 at 09:52 -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
>    config RESET_ZX2967
>           bool "ZTE ZX2967 Reset Driver
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since builtin_platform_driver() was already in use, the init ordering
> remains unchanged with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> We don't replace module.h with init.h since the file does not appear
> to use __init prefix anywhere.
> 
> Cc: Jun Nie <jun.nie@linaro.org>
> Cc: Baoyou Xie <baoyou.xie@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Thank you, applied with Baoyou's Reviewed-by.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] reset: make zx2967 explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-02-02 16:00 +0100
  Re: [PATCH] reset: make zx2967 explicitly non-modular Philipp Zabel <p.zabel@pengutronix.de> - 2017-02-02 16:40 +0100

csiph-web