Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1572177 > unrolled thread

Re: [PATCH v2 00/10] serial: st-asc: Allow handling of RTS line

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 00/10] serial: st-asc: Allow handling of RTS line Lee Jones <lee.jones@linaro.org> - 2017-02-02 08:50 +0100
    Re: [PATCH v2 00/10] serial: st-asc: Allow handling of RTS line Greg KH <gregkh@linuxfoundation.org> - 2017-02-02 11:00 +0100
      Re: [PATCH v2 00/10] serial: st-asc: Allow handling of RTS line Lee Jones <lee.jones@linaro.org> - 2017-02-03 10:30 +0100

#1572177 — Re: [PATCH v2 00/10] serial: st-asc: Allow handling of RTS line

Hi Greg, Jiri,

> When hardware flow-control is disabled, manual toggling of the UART's
> reset line (RTS) using userland applications (e.g. stty) is not
> possible, since the ASC IP does not provide this functionality in the
> same was as some other IPs do.  Thus, we have to do this manually.
> 
> This set ensures the correct Pinctrl groups are configured and
> obtained for both manual toggling of the RTS line and for the IP to
> take over the lines when HW flow-control is requested by the user. 
> 
> Lee Jones (10):
>   serial: st-asc: Ignore the parity error bit if 8-bit mode is enabled
>   serial: st-asc: Provide RTS functionality
>   serial: st-asc: Read in all Pinctrl states
>   serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles
>   serial: st-asc: Use generic DT binding for announcing RTS/CTS lines
>   dt-bindings: serial: Update 'uart-has-rtscts' description
>   ARM: dts: STiH410-b2260: Identify the UART RTS line
>   ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control
>   ARM: dts: STiH407-family: Use new Pinctrl groups
>   ARM: dts: STiH410-b2260: Enable HW flow-control
> 
>  .../devicetree/bindings/serial/serial.txt          |   3 +-
>  arch/arm/boot/dts/stih407-family.dtsi              |   3 +-
>  arch/arm/boot/dts/stih407-pinctrl.dtsi             |  12 ++-
>  arch/arm/boot/dts/stih410-b2260.dts                |   5 +
>  drivers/tty/serial/st-asc.c                        | 101 +++++++++++++++++++--
>  5 files changed, 110 insertions(+), 14 deletions(-)

Looks like everyone is happy with the set.

Are you planning to merge it?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]

#1572233

On Thu, Feb 02, 2017 at 07:42:36AM +0000, Lee Jones wrote:
> Hi Greg, Jiri,
> 
> > When hardware flow-control is disabled, manual toggling of the UART's
> > reset line (RTS) using userland applications (e.g. stty) is not
> > possible, since the ASC IP does not provide this functionality in the
> > same was as some other IPs do.  Thus, we have to do this manually.
> > 
> > This set ensures the correct Pinctrl groups are configured and
> > obtained for both manual toggling of the RTS line and for the IP to
> > take over the lines when HW flow-control is requested by the user. 
> > 
> > Lee Jones (10):
> >   serial: st-asc: Ignore the parity error bit if 8-bit mode is enabled
> >   serial: st-asc: Provide RTS functionality
> >   serial: st-asc: Read in all Pinctrl states
> >   serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles
> >   serial: st-asc: Use generic DT binding for announcing RTS/CTS lines
> >   dt-bindings: serial: Update 'uart-has-rtscts' description
> >   ARM: dts: STiH410-b2260: Identify the UART RTS line
> >   ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control
> >   ARM: dts: STiH407-family: Use new Pinctrl groups
> >   ARM: dts: STiH410-b2260: Enable HW flow-control
> > 
> >  .../devicetree/bindings/serial/serial.txt          |   3 +-
> >  arch/arm/boot/dts/stih407-family.dtsi              |   3 +-
> >  arch/arm/boot/dts/stih407-pinctrl.dtsi             |  12 ++-
> >  arch/arm/boot/dts/stih410-b2260.dts                |   5 +
> >  drivers/tty/serial/st-asc.c                        | 101 +++++++++++++++++++--
> >  5 files changed, 110 insertions(+), 14 deletions(-)
> 
> Looks like everyone is happy with the set.
> 
> Are you planning to merge it?

I'll take it in my next round of patches, give me a few days to sync up,
I normally do serial patches once a week or so.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1572965

On Thu, 02 Feb 2017, Greg KH wrote:

> On Thu, Feb 02, 2017 at 07:42:36AM +0000, Lee Jones wrote:
> > Hi Greg, Jiri,
> > 
> > > When hardware flow-control is disabled, manual toggling of the UART's
> > > reset line (RTS) using userland applications (e.g. stty) is not
> > > possible, since the ASC IP does not provide this functionality in the
> > > same was as some other IPs do.  Thus, we have to do this manually.
> > > 
> > > This set ensures the correct Pinctrl groups are configured and
> > > obtained for both manual toggling of the RTS line and for the IP to
> > > take over the lines when HW flow-control is requested by the user. 
> > > 
> > > Lee Jones (10):
> > >   serial: st-asc: Ignore the parity error bit if 8-bit mode is enabled
> > >   serial: st-asc: Provide RTS functionality
> > >   serial: st-asc: Read in all Pinctrl states
> > >   serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles
> > >   serial: st-asc: Use generic DT binding for announcing RTS/CTS lines
> > >   dt-bindings: serial: Update 'uart-has-rtscts' description
> > >   ARM: dts: STiH410-b2260: Identify the UART RTS line
> > >   ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control
> > >   ARM: dts: STiH407-family: Use new Pinctrl groups
> > >   ARM: dts: STiH410-b2260: Enable HW flow-control
> > > 
> > >  .../devicetree/bindings/serial/serial.txt          |   3 +-
> > >  arch/arm/boot/dts/stih407-family.dtsi              |   3 +-
> > >  arch/arm/boot/dts/stih407-pinctrl.dtsi             |  12 ++-
> > >  arch/arm/boot/dts/stih410-b2260.dts                |   5 +
> > >  drivers/tty/serial/st-asc.c                        | 101 +++++++++++++++++++--
> > >  5 files changed, 110 insertions(+), 14 deletions(-)
> > 
> > Looks like everyone is happy with the set.
> > 
> > Are you planning to merge it?
> 
> I'll take it in my next round of patches, give me a few days to sync up,
> I normally do serial patches once a week or so.

Works for me.  Thanks Greg.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web