Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1573544 > unrolled thread

[PATCH] Drivers: staging: speakup: spk_priv.h - style fix

Back to article view | Back to linux.kernel

Contents

  [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson <robsonde@gmail.com> - 2017-02-04 01:00 +0100
    Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson <robsonde@gmail.com> - 2017-02-04 04:40 +0100
      Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Joe Perches <joe@perches.com> - 2017-02-04 05:30 +0100
    Re: Drivers: staging: speakup: spk_priv.h - style fix Guenter Roeck <linux@roeck-us.net> - 2017-02-04 05:40 +0100

#1573544 — [PATCH] Drivers: staging: speakup: spk_priv.h - style fix

Changed function definition argument to have identifier name.
found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 drivers/staging/speakup/spk_priv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h
index 98c4b6f0344a..1952d7887b3b 100644
--- a/drivers/staging/speakup/spk_priv.h
+++ b/drivers/staging/speakup/spk_priv.h
@@ -64,8 +64,8 @@ void spk_synth_flush(struct spk_synth *synth);
 int spk_synth_is_alive_nop(struct spk_synth *synth);
 int spk_synth_is_alive_restart(struct spk_synth *synth);
 void synth_printf(const char *buf, ...);
-int synth_request_region(u_long, u_long);
-int synth_release_region(u_long, u_long);
+int synth_request_region(unsigned long start, unsigned long n)
+int synth_release_region(unsigned long start, unsigned long n)
 int synth_add(struct spk_synth *in_synth);
 void synth_remove(struct spk_synth *in_synth);
 
-- 
2.11.1

[toc] | [next] | [standalone]

#1573586

On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> Hi Derek,
> 
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.10-rc6 next-20170203]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All error/warnings (new ones prefixed by >>):
> 
>     #define param_check_int(name, p) __param_check(name, p, int)
>                                      ^~~~~~~~~~~~~
>    include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
>      param_check_##type(name, &(value));       \
>      ^~~~~~~~~~~~
>    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
>     module_param_named(ser, synth_acntsa.ser, int, 0444);
>     ^~~~~~~~~~~~~~~~~~
>    include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
>      param_check_##type(name, &(value));       \
>                                        ^
>    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
>     module_param_named(ser, synth_acntsa.ser, int, 0444);
>     ^~~~~~~~~~~~~~~~~~
>    include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
>      static const char __param_str_##name[] = prefix #name;  \

Can anyone tell me what I did wrong?
I don't think it was my patch that broke the build.

Thanks

[toc] | [prev] | [next] | [standalone]

#1573597

On Sat, 2017-02-04 at 16:31 +1300, Derek Robson wrote:
> On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> > Hi Derek,
> > 
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.10-rc6 next-20170203]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386 
> > 
> > All error/warnings (new ones prefixed by >>):
> > 
> >     #define param_check_int(name, p) __param_check(name, p, int)
> >                                      ^~~~~~~~~~~~~
> >    include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
> >      param_check_##type(name, &(value));       \
> >      ^~~~~~~~~~~~
> >    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> >     module_param_named(ser, synth_acntsa.ser, int, 0444);
> >     ^~~~~~~~~~~~~~~~~~
> >    include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
> >      param_check_##type(name, &(value));       \
> >                                        ^
> >    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> >     module_param_named(ser, synth_acntsa.ser, int, 0444);
> >     ^~~~~~~~~~~~~~~~~~
> >    include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
> >      static const char __param_str_##name[] = prefix #name;  \
> 
> Can anyone tell me what I did wrong?

You removed semicolons from the function prototypes.

-int synth_request_region(u_long, u_long);
-int synth_release_region(u_long, u_long);
+int synth_request_region(unsigned long start, unsigned long n)
+int synth_release_region(unsigned long start, unsigned long n)

> I don't think it was my patch that broke the build.

You should make sure you build test a patch
before sending it on to the list.

[toc] | [prev] | [next] | [standalone]

#1573599 — Re: Drivers: staging: speakup: spk_priv.h - style fix

On Sat, Feb 04, 2017 at 12:56:41PM +1300, Derek Robson wrote:
> Changed function definition argument to have identifier name.
> found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  drivers/staging/speakup/spk_priv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h
> index 98c4b6f0344a..1952d7887b3b 100644
> --- a/drivers/staging/speakup/spk_priv.h
> +++ b/drivers/staging/speakup/spk_priv.h
> @@ -64,8 +64,8 @@ void spk_synth_flush(struct spk_synth *synth);
>  int spk_synth_is_alive_nop(struct spk_synth *synth);
>  int spk_synth_is_alive_restart(struct spk_synth *synth);
>  void synth_printf(const char *buf, ...);
> -int synth_request_region(u_long, u_long);
> -int synth_release_region(u_long, u_long);
> +int synth_request_region(unsigned long start, unsigned long n)
> +int synth_release_region(unsigned long start, unsigned long n)

Hmmm .. you didn't compile test your code, did you ? 

You asked why 0day reports an error. If you compile this code,
I am quite sure that you are going to see the same errors.

Guenter

>  int synth_add(struct spk_synth *in_synth);
>  void synth_remove(struct spk_synth *in_synth);
>  

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web