Re: Drivers: staging: speakup: spk_priv.h - style fix

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: Drivers: staging: speakup: spk_priv.h - style fix
Date	2017-02-04 05:40 +0100
Message-ID	<t70iJ-3E0-5@gated-at.bofh.it> (permalink)
References	<t6VVM-kN-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Feb 04, 2017 at 12:56:41PM +1300, Derek Robson wrote:
> Changed function definition argument to have identifier name.
> found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  drivers/staging/speakup/spk_priv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h
> index 98c4b6f0344a..1952d7887b3b 100644
> --- a/drivers/staging/speakup/spk_priv.h
> +++ b/drivers/staging/speakup/spk_priv.h
> @@ -64,8 +64,8 @@ void spk_synth_flush(struct spk_synth *synth);
>  int spk_synth_is_alive_nop(struct spk_synth *synth);
>  int spk_synth_is_alive_restart(struct spk_synth *synth);
>  void synth_printf(const char *buf, ...);
> -int synth_request_region(u_long, u_long);
> -int synth_release_region(u_long, u_long);
> +int synth_request_region(unsigned long start, unsigned long n)
> +int synth_release_region(unsigned long start, unsigned long n)

Hmmm .. you didn't compile test your code, did you ? 

You asked why 0day reports an error. If you compile this code,
I am quite sure that you are going to see the same errors.

Guenter

>  int synth_add(struct spk_synth *in_synth);
>  void synth_remove(struct spk_synth *in_synth);
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson <robsonde@gmail.com> - 2017-02-04 01:00 +0100
  Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson <robsonde@gmail.com> - 2017-02-04 04:40 +0100
    Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Joe Perches <joe@perches.com> - 2017-02-04 05:30 +0100
  Re: Drivers: staging: speakup: spk_priv.h - style fix Guenter Roeck <linux@roeck-us.net> - 2017-02-04 05:40 +0100

csiph-web