Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1571587 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2017-02-01 15:40 +0100 |
| Last post | 2017-02-01 16:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines Lee Jones <lee.jones@linaro.org> - 2017-02-01 15:40 +0100
Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines Peter Griffin <peter.griffin@linaro.org> - 2017-02-01 16:00 +0100
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-02-01 15:40 +0100 |
| Subject | [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines |
| Message-ID | <t64eJ-77f-3@gated-at.bofh.it> |
The initial binding 'st,hw-flow-control' isn't used anywhere, in neither in upstream nor downstream kernels. It isn't even documented in dt-bindings, so we can safely assume it's safe to swap to the generic one. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/tty/serial/st-asc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c index e521078..bcf1d33 100644 --- a/drivers/tty/serial/st-asc.c +++ b/drivers/tty/serial/st-asc.c @@ -794,7 +794,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev) return NULL; asc_ports[id].hw_flow_control = of_property_read_bool(np, - "st,hw-flow-control"); + "uart-has-rtscts"); asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1"); asc_ports[id].port.line = id; asc_ports[id].rts = NULL; -- 2.9.3
[toc] | [next] | [standalone]
| From | Peter Griffin <peter.griffin@linaro.org> |
|---|---|
| Date | 2017-02-01 16:00 +0100 |
| Subject | Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines |
| Message-ID | <t64y5-7eg-9@gated-at.bofh.it> |
| In reply to | #1571587 |
On Wed, 01 Feb 2017, Lee Jones wrote: > The initial binding 'st,hw-flow-control' isn't used anywhere, in neither > in upstream nor downstream kernels. It isn't even documented in > dt-bindings, so we can safely assume it's safe to swap to the generic > one. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Peter Griffin <peter.griffin@linaro.org> > --- > drivers/tty/serial/st-asc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c > index e521078..bcf1d33 100644 > --- a/drivers/tty/serial/st-asc.c > +++ b/drivers/tty/serial/st-asc.c > @@ -794,7 +794,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev) > return NULL; > > asc_ports[id].hw_flow_control = of_property_read_bool(np, > - "st,hw-flow-control"); > + "uart-has-rtscts"); > asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1"); > asc_ports[id].port.line = id; > asc_ports[id].rts = NULL;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web