Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines

From	Peter Griffin <peter.griffin@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines
Date	2017-02-01 16:00 +0100
Message-ID	<t64y5-7eg-9@gated-at.bofh.it> (permalink)
References	<t64eJ-77f-5@gated-at.bofh.it> <t64eJ-77f-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 01 Feb 2017, Lee Jones wrote:

> The initial binding 'st,hw-flow-control' isn't used anywhere, in neither
> in upstream nor downstream kernels.  It isn't even documented in
> dt-bindings, so we can safely assume it's safe to swap to the generic
> one.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Peter Griffin <peter.griffin@linaro.org>

> ---
>  drivers/tty/serial/st-asc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index e521078..bcf1d33 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -794,7 +794,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
>  		return NULL;
>  
>  	asc_ports[id].hw_flow_control = of_property_read_bool(np,
> -							"st,hw-flow-control");
> +							"uart-has-rtscts");
>  	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force_m1");
>  	asc_ports[id].port.line = id;
>  	asc_ports[id].rts = NULL;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 05/10] serial: st-asc: Use generic DT binding for announcing RTS/CTS lines Lee Jones <lee.jones@linaro.org> - 2017-02-01 15:40 +0100
  Re: [STLinux Kernel] [PATCH v2 05/10] serial: st-asc: Use generic DT  binding for announcing RTS/CTS lines Peter Griffin <peter.griffin@linaro.org> - 2017-02-01 16:00 +0100

csiph-web