Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1571495 > unrolled thread
| Started by | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| First post | 2017-02-01 13:00 +0100 |
| Last post | 2017-02-01 13:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rtc: sun6i: extend test coverage Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-01 13:00 +0100
Re: [PATCH] rtc: sun6i: extend test coverage Arnd Bergmann <arnd@arndb.de> - 2017-02-01 13:20 +0100
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-02-01 13:00 +0100 |
| Subject | [PATCH] rtc: sun6i: extend test coverage |
| Message-ID | <t61JU-5tS-3@gated-at.bofh.it> |
COMPILE_TEST was wrongly placed, move it to the "depends on" line. Also, select COMMON_CLK has the driver now needs it to be properly compiled. Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> --- drivers/rtc/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index ee287cf63b01..06f3beb8e30f 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1435,8 +1435,9 @@ config RTC_DRV_SUN4V config RTC_DRV_SUN6I bool "Allwinner A31 RTC" - default MACH_SUN6I || MACH_SUN8I || COMPILE_TEST - depends on ARCH_SUNXI + default MACH_SUN6I || MACH_SUN8I + select COMMON_CLK + depends on ARCH_SUNXI || COMPILE_TEST help If you say Y here you will get support for the RTC found in some Allwinner SoCs like the A31 or the A64. -- 2.11.0
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-02-01 13:20 +0100 |
| Message-ID | <t623g-5RJ-15@gated-at.bofh.it> |
| In reply to | #1571495 |
On Wed, Feb 1, 2017 at 12:57 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> COMPILE_TEST was wrongly placed, move it to the "depends on" line. Also,
> select COMMON_CLK has the driver now needs it to be properly compiled.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index ee287cf63b01..06f3beb8e30f 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1435,8 +1435,9 @@ config RTC_DRV_SUN4V
>
> config RTC_DRV_SUN6I
> bool "Allwinner A31 RTC"
> - default MACH_SUN6I || MACH_SUN8I || COMPILE_TEST
> - depends on ARCH_SUNXI
> + default MACH_SUN6I || MACH_SUN8I
> + select COMMON_CLK
I think this needs to be "depends on COMMON_CLK", otherwise it looks good.
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web