Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571505

Re: [PATCH] rtc: sun6i: extend test coverage

Show all headers | View raw

On Wed, Feb 1, 2017 at 12:57 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> COMPILE_TEST was wrongly placed, move it to the "depends on" line. Also,
> select COMMON_CLK has the driver now needs it to be properly compiled.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/rtc/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index ee287cf63b01..06f3beb8e30f 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1435,8 +1435,9 @@ config RTC_DRV_SUN4V
>
>  config RTC_DRV_SUN6I
>         bool "Allwinner A31 RTC"
> -       default MACH_SUN6I || MACH_SUN8I || COMPILE_TEST
> -       depends on ARCH_SUNXI
> +       default MACH_SUN6I || MACH_SUN8I
> +       select COMMON_CLK

I think this needs to be "depends on COMMON_CLK", otherwise it looks good.

     Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: sun6i: extend test coverage Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-01 13:00 +0100
  Re: [PATCH] rtc: sun6i: extend test coverage Arnd Bergmann <arnd@arndb.de> - 2017-02-01 13:20 +0100

csiph-web