Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1570183 > unrolled thread
| Started by | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| First post | 2017-01-31 00:40 +0100 |
| Last post | 2017-01-31 04:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-31 00:40 +0100
Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-31 04:40 +0100
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| Date | 2017-01-31 00:40 +0100 |
| Subject | Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver |
| Message-ID | <t5tId-1Kd-3@gated-at.bofh.it> |
On Fri, Jan 06, 2017 at 06:11:40PM -0800, Steve Longerbeam wrote: > +config IMX_OV5640_MIPI > + tristate "OmniVision OV5640 MIPI CSI-2 camera support" > + depends on GPIOLIB && VIDEO_IMX_CAMERA > + select IMX_MIPI_CSI2 > + default y Why is this defaulting to y? New drivers should not default to enabled unless they are replacing some already pre-existing functionality. Ditto for the other camera driver. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
[toc] | [next] | [standalone]
| From | Steve Longerbeam <slongerbeam@gmail.com> |
|---|---|
| Date | 2017-01-31 04:40 +0100 |
| Message-ID | <t5xst-437-3@gated-at.bofh.it> |
| In reply to | #1570183 |
On 01/30/2017 03:29 PM, Russell King - ARM Linux wrote: > On Fri, Jan 06, 2017 at 06:11:40PM -0800, Steve Longerbeam wrote: >> +config IMX_OV5640_MIPI >> + tristate "OmniVision OV5640 MIPI CSI-2 camera support" >> + depends on GPIOLIB && VIDEO_IMX_CAMERA >> + select IMX_MIPI_CSI2 >> + default y > Why is this defaulting to y? New drivers should not default to enabled > unless they are replacing some already pre-existing functionality. > Ditto for the other camera driver. The ov564x sensors are required for the SabreSD and SabreLite/Nitrogen reference boards (if VIDEO_IMX_CAMERA is enabled that is). But they're not required for other platforms, so you're right I shouldn't have defaulted these to yes. Fixed. Steve
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web