Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

From	Steve Longerbeam <slongerbeam@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver
Date	2017-01-31 04:40 +0100
Message-ID	<t5xst-437-3@gated-at.bofh.it> (permalink)
References	<sWOLT-2qI-3@gated-at.bofh.it> <sWOLT-2qI-17@gated-at.bofh.it> <t5tId-1Kd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/30/2017 03:29 PM, Russell King - ARM Linux wrote:
> On Fri, Jan 06, 2017 at 06:11:40PM -0800, Steve Longerbeam wrote:
>> +config IMX_OV5640_MIPI
>> +       tristate "OmniVision OV5640 MIPI CSI-2 camera support"
>> +       depends on GPIOLIB && VIDEO_IMX_CAMERA
>> +       select IMX_MIPI_CSI2
>> +       default y
> Why is this defaulting to y?  New drivers should not default to enabled
> unless they are replacing some already pre-existing functionality.
> Ditto for the other camera driver.

The ov564x sensors are required for the SabreSD and SabreLite/Nitrogen
reference boards (if VIDEO_IMX_CAMERA is enabled that is). But they're not
required for other platforms, so you're right I shouldn't have defaulted 
these
to yes. Fixed.

Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev  driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-31 00:40 +0100
  Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev  driver Steve Longerbeam <slongerbeam@gmail.com> - 2017-01-31 04:40 +0100

csiph-web