Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571037 > unrolled thread

Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of  Gamers" laptop Daniel Drake <drake@endlessm.com> - 2017-01-31 20:50 +0100
    Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of  Gamers" laptop Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-02-01 09:20 +0100

#1571037 — Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

Hi Benjamin,

On Tue, Dec 13, 2016 at 2:16 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> On Dec 12 2016 or thereabouts, Chris Chiu wrote:
>> ROG means ASUS "Republic of Gamers" laptops. The input device info
>> also represents itself as "ASASTeK COMPUTER INC. ROG MacroKey". It
>> uses special HID_USAGE code for function keys. This commit remap the
>> special code to standard keycode for function keys handling. It's
>> verified on GL553VD/VE, GL753VD/VE.
>>
>> Signed-off-by: Chris Chiu <chiu@endlessm.com>
>> Reported-by: Yukai Li <yukaili@gmail.com>
>> ---
>
> Hi Chris,
>
> there is no real point of having a separate driver from hid-asus. The
> HID tree prefer to group drivers by vendors, so these keyboards should
> be supported through hid-asus.

Thanks for the feedback. We will submit a new version soon.

Just to confirm, hid-asus currently depends on I2C_HID. The new
devices being quirked now are USB devices. With this patch should we
now update it to depend on I2C_HID && USB_HID?

Daniel

[toc] | [next] | [standalone]

#1571319

On Jan 31 2017 or thereabouts, Daniel Drake wrote:
> Hi Benjamin,
> 
> On Tue, Dec 13, 2016 at 2:16 AM, Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> > On Dec 12 2016 or thereabouts, Chris Chiu wrote:
> >> ROG means ASUS "Republic of Gamers" laptops. The input device info
> >> also represents itself as "ASASTeK COMPUTER INC. ROG MacroKey". It
> >> uses special HID_USAGE code for function keys. This commit remap the
> >> special code to standard keycode for function keys handling. It's
> >> verified on GL553VD/VE, GL753VD/VE.
> >>
> >> Signed-off-by: Chris Chiu <chiu@endlessm.com>
> >> Reported-by: Yukai Li <yukaili@gmail.com>
> >> ---
> >
> > Hi Chris,
> >
> > there is no real point of having a separate driver from hid-asus. The
> > HID tree prefer to group drivers by vendors, so these keyboards should
> > be supported through hid-asus.
> 
> Thanks for the feedback. We will submit a new version soon.
> 
> Just to confirm, hid-asus currently depends on I2C_HID. The new
> devices being quirked now are USB devices. With this patch should we
> now update it to depend on I2C_HID && USB_HID?
> 

Actually you can remove the I2C_HID dependency entirely (and not add one
for USB_HID). In the Kconfig, the modules are already guarded by a
"if HID", and there is nothing transport specific in hid-asus as far as
I can tell.

Note: we should also probably clean up the Kconfig once again and remove
all the "depends on HID" for those that are guarded by the if statement.

Cheers,
Benjamin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web