Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571037

Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of Gamers" laptop

Show all headers | View raw

Hi Benjamin,

On Tue, Dec 13, 2016 at 2:16 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> On Dec 12 2016 or thereabouts, Chris Chiu wrote:
>> ROG means ASUS "Republic of Gamers" laptops. The input device info
>> also represents itself as "ASASTeK COMPUTER INC. ROG MacroKey". It
>> uses special HID_USAGE code for function keys. This commit remap the
>> special code to standard keycode for function keys handling. It's
>> verified on GL553VD/VE, GL753VD/VE.
>>
>> Signed-off-by: Chris Chiu <chiu@endlessm.com>
>> Reported-by: Yukai Li <yukaili@gmail.com>
>> ---
>
> Hi Chris,
>
> there is no real point of having a separate driver from hid-asus. The
> HID tree prefer to group drivers by vendors, so these keyboards should
> be supported through hid-asus.

Thanks for the feedback. We will submit a new version soon.

Just to confirm, hid-asus currently depends on I2C_HID. The new
devices being quirked now are USB devices. With this patch should we
now update it to depend on I2C_HID && USB_HID?

Daniel

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of  Gamers" laptop Daniel Drake <drake@endlessm.com> - 2017-01-31 20:50 +0100
  Re: [PATCH] HID: add Asus macrokey support for Asus "Republic of  Gamers" laptop Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-02-01 09:20 +0100

csiph-web