Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1568448 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-01-27 16:40 +0100 |
| Last post | 2017-01-30 00:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][net-next] net: ethernet: aquantia: remove another redundant err check Colin King <colin.king@canonical.com> - 2017-01-27 16:40 +0100
Re: [PATCH][net-next] net: ethernet: aquantia: remove another redundant err check David Miller <davem@davemloft.net> - 2017-01-30 00:30 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-01-27 16:40 +0100 |
| Subject | [PATCH][net-next] net: ethernet: aquantia: remove another redundant err check |
| Message-ID | <t4gN4-5TS-19@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The check on err < 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398318 ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index b517b26..817c145 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -304,8 +304,6 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
buff = NULL;
}
- if (err < 0)
- goto err_exit;
err_exit:
if (err < 0) {
--
2.10.2
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-01-30 00:30 +0100 |
| Subject | Re: [PATCH][net-next] net: ethernet: aquantia: remove another redundant err check |
| Message-ID | <t5750-4Y3-25@gated-at.bofh.it> |
| In reply to | #1568448 |
From: Colin King <colin.king@canonical.com>
Date: Fri, 27 Jan 2017 15:00:25 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> The check on err < 0 is redundant and can be removed. Detected
> by CoverityScan, CID#1398318 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web