[PATCH][net-next] net: ethernet: aquantia: remove another redundant err check

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH][net-next] net: ethernet: aquantia: remove another redundant err check
Date	2017-01-27 16:40 +0100
Message-ID	<t4gN4-5TS-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The check on err < 0 is redundant and can be removed. Detected
by CoverityScan, CID#1398318 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index b517b26..817c145 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -304,8 +304,6 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
 
 		buff = NULL;
 	}
-	if (err < 0)
-		goto err_exit;
 
 err_exit:
 	if (err < 0) {
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] net: ethernet: aquantia: remove another redundant err check Colin King <colin.king@canonical.com> - 2017-01-27 16:40 +0100
  Re: [PATCH][net-next] net: ethernet: aquantia: remove another  redundant err check David Miller <davem@davemloft.net> - 2017-01-30 00:30 +0100

csiph-web