Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567923 > unrolled thread
| Started by | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| First post | 2017-01-27 09:00 +0100 |
| Last post | 2017-01-27 11:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Kalle Valo <kvalo@codeaurora.org> - 2017-01-27 09:00 +0100
Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Kalle Valo <kvalo@codeaurora.org> - 2017-01-27 10:50 +0100
Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Pali Rohár <pali.rohar@gmail.com> - 2017-01-27 11:10 +0100
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-01-27 09:00 +0100 |
| Subject | Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data |
| Message-ID | <t49BT-1ni-9@gated-at.bofh.it> |
Pali Rohár <pali.rohar@gmail.com> writes: > In case there is no valid MAC address kernel generates random one. This > patch propagate this generated MAC address back to NVS data which will be > uploaded to wl1251 chip. So HW would have same MAC address as linux kernel > uses. > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> Why? What issue does this fix? -- Kalle Valo
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2017-01-27 10:50 +0100 |
| Message-ID | <t4bkm-2qx-21@gated-at.bofh.it> |
| In reply to | #1567923 |
Pali Rohár <pali.rohar@gmail.com> writes: > On Friday 27 January 2017 09:56:09 Kalle Valo wrote: >> Pali Rohár <pali.rohar@gmail.com> writes: >> >> > In case there is no valid MAC address kernel generates random one. This >> > patch propagate this generated MAC address back to NVS data which will be >> > uploaded to wl1251 chip. So HW would have same MAC address as linux kernel >> > uses. >> > >> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> >> >> Why? What issue does this fix? > > Send permanent MAC address to wl1251 chip, same what is doing wl12xx > driver. Ok, so this doesn't change functionality in any way and you are adding it only because wl12xx does the same? You should document that in the the commit log. If there's no change I don't really see the point of this. But if there's harm, hopefully, I guess it's ok. -- Kalle Valo
[toc] | [prev] | [next] | [standalone]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2017-01-27 11:10 +0100 |
| Message-ID | <t4bkm-2qx-23@gated-at.bofh.it> |
| In reply to | #1567923 |
On Friday 27 January 2017 09:56:09 Kalle Valo wrote: > Pali Rohár <pali.rohar@gmail.com> writes: > > > In case there is no valid MAC address kernel generates random one. This > > patch propagate this generated MAC address back to NVS data which will be > > uploaded to wl1251 chip. So HW would have same MAC address as linux kernel > > uses. > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > Why? What issue does this fix? Send permanent MAC address to wl1251 chip, same what is doing wl12xx driver. -- Pali Rohár pali.rohar@gmail.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web