Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567992
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data |
| Date | 2017-01-27 10:50 +0100 |
| Message-ID | <t4bkm-2qx-21@gated-at.bofh.it> (permalink) |
| References | <sRXPQ-Xz-5@gated-at.bofh.it> <sRXZv-1gP-21@gated-at.bofh.it> <t49BT-1ni-9@gated-at.bofh.it> <t4bkm-2qx-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Pali Rohár <pali.rohar@gmail.com> writes: > On Friday 27 January 2017 09:56:09 Kalle Valo wrote: >> Pali Rohár <pali.rohar@gmail.com> writes: >> >> > In case there is no valid MAC address kernel generates random one. This >> > patch propagate this generated MAC address back to NVS data which will be >> > uploaded to wl1251 chip. So HW would have same MAC address as linux kernel >> > uses. >> > >> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> >> >> Why? What issue does this fix? > > Send permanent MAC address to wl1251 chip, same what is doing wl12xx > driver. Ok, so this doesn't change functionality in any way and you are adding it only because wl12xx does the same? You should document that in the the commit log. If there's no change I don't really see the point of this. But if there's harm, hopefully, I guess it's ok. -- Kalle Valo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Kalle Valo <kvalo@codeaurora.org> - 2017-01-27 09:00 +0100 Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Kalle Valo <kvalo@codeaurora.org> - 2017-01-27 10:50 +0100 Re: [PATCH 6/6] wl1251: Set generated MAC address back to NVS data Pali Rohár <pali.rohar@gmail.com> - 2017-01-27 11:10 +0100
csiph-web