Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1565153 > unrolled thread
| Started by | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| First post | 2017-01-23 18:10 +0100 |
| Last post | 2017-01-27 11:30 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-23 18:10 +0100
Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Grygorii Strashko <grygorii.strashko@ti.com> - 2017-01-26 18:10 +0100
Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Sekhar Nori <nsekhar@ti.com> - 2017-01-26 18:50 +0100
Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Sekhar Nori <nsekhar@ti.com> - 2017-01-27 11:10 +0100
Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-27 11:30 +0100
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-01-23 18:10 +0100 |
| Subject | [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock |
| Message-ID | <t2QhY-Jd-33@gated-at.bofh.it> |
The ahci-da850 SATA driver is now capable of retrieving clocks by
con_id. Add the connection id for the sysclk2-derived SATA clock.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/mach-davinci/da850.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
index 1d873d1..dbf1daa 100644
--- a/arch/arm/mach-davinci/da850.c
+++ b/arch/arm/mach-davinci/da850.c
@@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
CLK("spi_davinci.0", NULL, &spi0_clk),
CLK("spi_davinci.1", NULL, &spi1_clk),
CLK("vpif", NULL, &vpif_clk),
- CLK("ahci_da850", NULL, &sata_clk),
+ CLK("ahci_da850", "sata", &sata_clk),
CLK("davinci-rproc.0", NULL, &dsp_clk),
CLK(NULL, NULL, &ehrpwm_clk),
CLK("ehrpwm.0", "fck", &ehrpwm0_clk),
--
2.9.3
[toc] | [next] | [standalone]
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2017-01-26 18:10 +0100 |
| Subject | Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock |
| Message-ID | <t3VIC-1CL-17@gated-at.bofh.it> |
| In reply to | #1565153 |
On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote:
> The ahci-da850 SATA driver is now capable of retrieving clocks by
> con_id. Add the connection id for the sysclk2-derived SATA clock.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/mach-davinci/da850.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> index 1d873d1..dbf1daa 100644
> --- a/arch/arm/mach-davinci/da850.c
> +++ b/arch/arm/mach-davinci/da850.c
> @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
> CLK("spi_davinci.0", NULL, &spi0_clk),
> CLK("spi_davinci.1", NULL, &spi1_clk),
> CLK("vpif", NULL, &vpif_clk),
> - CLK("ahci_da850", NULL, &sata_clk),
> + CLK("ahci_da850", "sata", &sata_clk),
I'm worry a bit - wouldn't this cause future problems with PM runtime
(if it will be the case)?
If this is functional clock - shouldn't it be "fck" to
follow PM domain con_id list for davinci? (arch/arm/mach-davinci/pm_domain.c)
> CLK("davinci-rproc.0", NULL, &dsp_clk),
> CLK(NULL, NULL, &ehrpwm_clk),
> CLK("ehrpwm.0", "fck", &ehrpwm0_clk),
>
--
regards,
-grygorii
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-01-26 18:50 +0100 |
| Subject | Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock |
| Message-ID | <t3Wlk-1PQ-31@gated-at.bofh.it> |
| In reply to | #1567604 |
On Thursday 26 January 2017 10:26 PM, Grygorii Strashko wrote:
>
>
> On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote:
>> The ahci-da850 SATA driver is now capable of retrieving clocks by
>> con_id. Add the connection id for the sysclk2-derived SATA clock.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> arch/arm/mach-davinci/da850.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
>> index 1d873d1..dbf1daa 100644
>> --- a/arch/arm/mach-davinci/da850.c
>> +++ b/arch/arm/mach-davinci/da850.c
>> @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
>> CLK("spi_davinci.0", NULL, &spi0_clk),
>> CLK("spi_davinci.1", NULL, &spi1_clk),
>> CLK("vpif", NULL, &vpif_clk),
>> - CLK("ahci_da850", NULL, &sata_clk),
>> + CLK("ahci_da850", "sata", &sata_clk),
>
> I'm worry a bit - wouldn't this cause future problems with PM runtime
> (if it will be the case)?
>
> If this is functional clock - shouldn't it be "fck" to
> follow PM domain con_id list for davinci? (arch/arm/mach-davinci/pm_domain.c)
I agree with Grygorii. Calling this clock "fck" will make it easy to
convert the DA850 AHCI driver to use pm_runtime at a future date (no
mach-davinci changes should be needed).
Sorry about not spotting this earlier.
Thanks,
Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-01-27 11:10 +0100 |
| Subject | Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock |
| Message-ID | <t4bDH-2M6-7@gated-at.bofh.it> |
| In reply to | #1567634 |
On Friday 27 January 2017 03:25 PM, Bartosz Golaszewski wrote: > Hi Sekhar, > > I'll wait with sending v7 until we get an ack from Rob for the > ahci-da850 bindings, so that we don't fall to the bottom of the review > queue again. Yes, makes sense. Regards, Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-01-27 11:30 +0100 |
| Message-ID | <t4bDH-2M6-9@gated-at.bofh.it> |
| In reply to | #1567634 |
2017-01-26 18:40 GMT+01:00 Sekhar Nori <nsekhar@ti.com>:
> On Thursday 26 January 2017 10:26 PM, Grygorii Strashko wrote:
>>
>>
>> On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote:
>>> The ahci-da850 SATA driver is now capable of retrieving clocks by
>>> con_id. Add the connection id for the sysclk2-derived SATA clock.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>> ---
>>> arch/arm/mach-davinci/da850.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
>>> index 1d873d1..dbf1daa 100644
>>> --- a/arch/arm/mach-davinci/da850.c
>>> +++ b/arch/arm/mach-davinci/da850.c
>>> @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
>>> CLK("spi_davinci.0", NULL, &spi0_clk),
>>> CLK("spi_davinci.1", NULL, &spi1_clk),
>>> CLK("vpif", NULL, &vpif_clk),
>>> - CLK("ahci_da850", NULL, &sata_clk),
>>> + CLK("ahci_da850", "sata", &sata_clk),
>>
>> I'm worry a bit - wouldn't this cause future problems with PM runtime
>> (if it will be the case)?
>>
>> If this is functional clock - shouldn't it be "fck" to
>> follow PM domain con_id list for davinci? (arch/arm/mach-davinci/pm_domain.c)
>
> I agree with Grygorii. Calling this clock "fck" will make it easy to
> convert the DA850 AHCI driver to use pm_runtime at a future date (no
> mach-davinci changes should be needed).
>
> Sorry about not spotting this earlier.
>
Hi Sekhar,
I'll wait with sending v7 until we get an ack from Rob for the
ahci-da850 bindings, so that we don't fall to the bottom of the review
queue again.
Thanks,
Bartosz
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web