Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock

From	Sekhar Nori <nsekhar@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock
Date	2017-01-26 18:50 +0100
Message-ID	<t3Wlk-1PQ-31@gated-at.bofh.it> (permalink)
References	<t2QhY-Jd-9@gated-at.bofh.it> <t2QhY-Jd-33@gated-at.bofh.it> <t3VIC-1CL-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 26 January 2017 10:26 PM, Grygorii Strashko wrote:
> 
> 
> On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote:
>> The ahci-da850 SATA driver is now capable of retrieving clocks by
>> con_id. Add the connection id for the sysclk2-derived SATA clock.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>>  arch/arm/mach-davinci/da850.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
>> index 1d873d1..dbf1daa 100644
>> --- a/arch/arm/mach-davinci/da850.c
>> +++ b/arch/arm/mach-davinci/da850.c
>> @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
>>  	CLK("spi_davinci.0",	NULL,		&spi0_clk),
>>  	CLK("spi_davinci.1",	NULL,		&spi1_clk),
>>  	CLK("vpif",		NULL,		&vpif_clk),
>> -	CLK("ahci_da850",		NULL,		&sata_clk),
>> +	CLK("ahci_da850",	"sata",		&sata_clk),
> 
> I'm worry a bit - wouldn't this cause future problems with PM runtime
>  (if it will be the case)?
> 
> If this is functional clock - shouldn't it be "fck" to 
> follow PM domain con_id list for davinci?  (arch/arm/mach-davinci/pm_domain.c) 

I agree with Grygorii. Calling this clock "fck" will make it easy to
convert the DA850 AHCI driver to use pm_runtime at a future date (no
mach-davinci changes should be needed).

Sorry about not spotting this earlier.

Thanks,
Sekhar

Thread

[PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-23 18:10 +0100
  Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA  clock Grygorii Strashko <grygorii.strashko@ti.com> - 2017-01-26 18:10 +0100
    Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA  clock Sekhar Nori <nsekhar@ti.com> - 2017-01-26 18:50 +0100
      Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA  clock Sekhar Nori <nsekhar@ti.com> - 2017-01-27 11:10 +0100
      Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-27 11:30 +0100

csiph-web