Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1566771 > unrolled thread
| Started by | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| First post | 2017-01-25 18:20 +0100 |
| Last post | 2017-01-25 20:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-25 18:20 +0100
Re: [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() Andrew Lunn <andrew@lunn.ch> - 2017-01-25 19:10 +0100
Re: [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() David Miller <davem@davemloft.net> - 2017-01-25 20:50 +0100
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-01-25 18:20 +0100 |
| Subject | [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() |
| Message-ID | <t3zoK-4A0-13@gated-at.bofh.it> |
Commit 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid
lockdep splat") removed the netif_device_detach() call done in
dsa_slave_suspend() which is necessary, and paired with a corresponding
netif_device_attach(), bring it back.
Fixes: 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid lockdep splat")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
David,
Can you also queue this for -stable? Thanks!
net/dsa/slave.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 68c9eea00518..020a28d5c93e 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1203,6 +1203,8 @@ int dsa_slave_suspend(struct net_device *slave_dev)
{
struct dsa_slave_priv *p = netdev_priv(slave_dev);
+ netif_device_detach(slave_dev);
+
if (p->phy) {
phy_stop(p->phy);
p->old_pause = -1;
--
2.9.3
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-01-25 19:10 +0100 |
| Subject | Re: [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() |
| Message-ID | <t3Ab8-57b-9@gated-at.bofh.it> |
| In reply to | #1566771 |
On Wed, Jan 25, 2017 at 09:10:41AM -0800, Florian Fainelli wrote:
> Commit 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid
> lockdep splat") removed the netif_device_detach() call done in
> dsa_slave_suspend() which is necessary, and paired with a corresponding
> netif_device_attach(), bring it back.
>
> Fixes: 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid lockdep splat")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Sorry for accidentally removing it.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-01-25 20:50 +0100 |
| Subject | Re: [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() |
| Message-ID | <t3BJT-5ZU-19@gated-at.bofh.it> |
| In reply to | #1566771 |
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 25 Jan 2017 09:10:41 -0800
> Commit 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid
> lockdep splat") removed the netif_device_detach() call done in
> dsa_slave_suspend() which is necessary, and paired with a corresponding
> netif_device_attach(), bring it back.
>
> Fixes: 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid lockdep splat")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> David,
>
> Can you also queue this for -stable? Thanks!
Applied and queued up for -stable, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web