Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1566803

Re: [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend()

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend()
Date 2017-01-25 19:10 +0100
Message-ID <t3Ab8-57b-9@gated-at.bofh.it> (permalink)
References <t3zoK-4A0-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jan 25, 2017 at 09:10:41AM -0800, Florian Fainelli wrote:
> Commit 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid
> lockdep splat") removed the netif_device_detach() call done in
> dsa_slave_suspend() which is necessary, and paired with a corresponding
> netif_device_attach(), bring it back.
> 
> Fixes: 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid lockdep splat")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Sorry for accidentally removing it.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net] net: dsa: Bring back device detaching in dsa_slave_suspend() Florian Fainelli <f.fainelli@gmail.com> - 2017-01-25 18:20 +0100
  Re: [PATCH net] net: dsa: Bring back device detaching in  dsa_slave_suspend() Andrew Lunn <andrew@lunn.ch> - 2017-01-25 19:10 +0100
  Re: [PATCH net] net: dsa: Bring back device detaching in  dsa_slave_suspend() David Miller <davem@davemloft.net> - 2017-01-25 20:50 +0100

csiph-web