Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562601 > unrolled thread

[PATCH] cxl: drop unused header asm/pnv-pci.h

Back to article view | Back to linux.kernel

Contents

  [PATCH] cxl: drop unused header asm/pnv-pci.h Greg Kurz <groug@kaod.org> - 2017-01-19 12:00 +0100
    Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2017-01-19 15:30 +0100
    Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Frederic Barrat <fbarrat@linux.vnet.ibm.com> - 2017-01-21 19:50 +0100
    Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Michael Ellerman <mpe@ellerman.id.au> - 2017-01-24 11:00 +0100
      Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Greg Kurz <groug@kaod.org> - 2017-01-24 12:50 +0100
      Re: [PATCH] cxl: drop unused header asm/pnv-pci.h Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2017-01-25 00:30 +0100
    Re: cxl: drop unused header asm/pnv-pci.h Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-01-27 01:50 +0100

#1562601 — [PATCH] cxl: drop unused header asm/pnv-pci.h

The kernel API does not use anything from this header file.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 drivers/misc/cxl/api.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index 1b35e33d2434..bcc030eacab7 100644
--- a/drivers/misc/cxl/api.c
+++ b/drivers/misc/cxl/api.c
@@ -11,7 +11,6 @@
 #include <linux/slab.h>
 #include <linux/file.h>
 #include <misc/cxl.h>
-#include <asm/pnv-pci.h>
 #include <linux/msi.h>
 #include <linux/module.h>
 #include <linux/mount.h>

[toc] | [next] | [standalone]

#1562771

On 19/01/17 21:50, Greg Kurz wrote:
> The kernel API does not use anything from this header file.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>


-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

[toc] | [prev] | [next] | [standalone]

#1564208

Le 19/01/2017 à 04:50, Greg Kurz a écrit :
> The kernel API does not use anything from this header file.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---

Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>

[toc] | [prev] | [next] | [standalone]

#1565750

Greg Kurz <groug@kaod.org> writes:

> The kernel API does not use anything from this header file.

That's actually hard to prove in general, because pnv-pci.h includes
linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
asm/opal-api.h. At least four of which aren't included directly by
api.c.

But I'll take you word for it :)

cheers

> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 1b35e33d2434..bcc030eacab7 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -11,7 +11,6 @@
>  #include <linux/slab.h>
>  #include <linux/file.h>
>  #include <misc/cxl.h>
> -#include <asm/pnv-pci.h>
>  #include <linux/msi.h>
>  #include <linux/module.h>
>  #include <linux/mount.h>

[toc] | [prev] | [next] | [standalone]

#1565796

On Tue, 24 Jan 2017 20:57:06 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:

> Greg Kurz <groug@kaod.org> writes:
> 
> > The kernel API does not use anything from this header file.  
> 
> That's actually hard to prove in general, because pnv-pci.h includes
> linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
> asm/opal-api.h. At least four of which aren't included directly by
> api.c.
> 
> But I'll take you word for it :)
> 

Sorry for the lack of details...

api.c doesn't do anything related to pci hotplug, nor to OPAL. This
happens in pci.c.

It includes cxl.h which includes misc/cxl-base.h.

The only generic irq bits are irq_hw_number_t, provided by linux/types.h,
and irq_find_mapping(), provided by linux/irqdomain.h, which is included
by misc/cxl-base.h -> linux/interrupt.h -> asm/irq.h.

Cheers (and congrats :)

--
Greg


> cheers
> 
> > diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> > index 1b35e33d2434..bcc030eacab7 100644
> > --- a/drivers/misc/cxl/api.c
> > +++ b/drivers/misc/cxl/api.c
> > @@ -11,7 +11,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/file.h>
> >  #include <misc/cxl.h>
> > -#include <asm/pnv-pci.h>
> >  #include <linux/msi.h>
> >  #include <linux/module.h>
> >  #include <linux/mount.h>  

[toc] | [prev] | [next] | [standalone]

#1566226

On 24/01/17 20:57, Michael Ellerman wrote:
> Greg Kurz <groug@kaod.org> writes:
>
>> The kernel API does not use anything from this header file.
>
> That's actually hard to prove in general, because pnv-pci.h includes
> linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
> asm/opal-api.h. At least four of which aren't included directly by
> api.c.
>
> But I'll take you word for it :)

I did compile test it before giving my Reviewed-by.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

[toc] | [prev] | [next] | [standalone]

#1567846 — Re: cxl: drop unused header asm/pnv-pci.h

On Thu, 2017-01-19 at 10:50:10 UTC, Greg Kurz wrote:
> The kernel API does not use anything from this header file.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/0e17166d377e74164e4067ae162ed1

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web