Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1565724 > unrolled thread

[PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence

Started byRitesh Harjani <riteshh@codeaurora.org>
First post2017-01-24 10:00 +0100
Last post2017-01-30 11:20 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence Ritesh Harjani <riteshh@codeaurora.org> - 2017-01-24 10:00 +0100
    Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC  init sequence Adrian Hunter <adrian.hunter@intel.com> - 2017-01-30 10:20 +0100
    Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC  init sequence Ulf Hansson <ulf.hansson@linaro.org> - 2017-01-30 11:20 +0100

#1565724 — [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence

FromRitesh Harjani <riteshh@codeaurora.org>
Date2017-01-24 10:00 +0100
Subject[PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence
Message-ID<t357l-24T-35@gated-at.bofh.it>
This removes CDC init sequence comments which are
not useful anyway.

Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
---
 drivers/mmc/host/sdhci-msm.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index b3e8f44..10cdc84 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -664,19 +664,7 @@ static int sdhci_msm_cdclp533_calibration(struct sdhci_host *host)
 	config &= ~CORE_START_CDC_TRAFFIC;
 	writel_relaxed(config, host->ioaddr + CORE_DDR_200_CFG);
 
-	/*
-	 * Perform CDC Register Initialization Sequence
-	 *
-	 * CORE_CSR_CDC_CTLR_CFG0	0x11800EC
-	 * CORE_CSR_CDC_CTLR_CFG1	0x3011111
-	 * CORE_CSR_CDC_CAL_TIMER_CFG0	0x1201000
-	 * CORE_CSR_CDC_CAL_TIMER_CFG1	0x4
-	 * CORE_CSR_CDC_REFCOUNT_CFG	0xCB732020
-	 * CORE_CSR_CDC_COARSE_CAL_CFG	0xB19
-	 * CORE_CSR_CDC_DELAY_CFG	0x3AC
-	 * CORE_CDC_OFFSET_CFG		0x0
-	 * CORE_CDC_SLAVE_DDA_CFG	0x16334
-	 */
+	/* Perform CDC Register Initialization Sequence */
 
 	writel_relaxed(0x11800EC, host->ioaddr + CORE_CSR_CDC_CTLR_CFG0);
 	writel_relaxed(0x3011111, host->ioaddr + CORE_CSR_CDC_CTLR_CFG1);
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
a Linux Foundation Collaborative Project.

[toc] | [next] | [standalone]


#1569486 — Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence

FromAdrian Hunter <adrian.hunter@intel.com>
Date2017-01-30 10:20 +0100
SubjectRe: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence
Message-ID<t5ghY-2bl-11@gated-at.bofh.it>
In reply to#1565724
On 24/01/17 10:50, Ritesh Harjani wrote:
> This removes CDC init sequence comments which are
> not useful anyway.
> 
> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-msm.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index b3e8f44..10cdc84 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -664,19 +664,7 @@ static int sdhci_msm_cdclp533_calibration(struct sdhci_host *host)
>  	config &= ~CORE_START_CDC_TRAFFIC;
>  	writel_relaxed(config, host->ioaddr + CORE_DDR_200_CFG);
>  
> -	/*
> -	 * Perform CDC Register Initialization Sequence
> -	 *
> -	 * CORE_CSR_CDC_CTLR_CFG0	0x11800EC
> -	 * CORE_CSR_CDC_CTLR_CFG1	0x3011111
> -	 * CORE_CSR_CDC_CAL_TIMER_CFG0	0x1201000
> -	 * CORE_CSR_CDC_CAL_TIMER_CFG1	0x4
> -	 * CORE_CSR_CDC_REFCOUNT_CFG	0xCB732020
> -	 * CORE_CSR_CDC_COARSE_CAL_CFG	0xB19
> -	 * CORE_CSR_CDC_DELAY_CFG	0x3AC
> -	 * CORE_CDC_OFFSET_CFG		0x0
> -	 * CORE_CDC_SLAVE_DDA_CFG	0x16334
> -	 */
> +	/* Perform CDC Register Initialization Sequence */
>  
>  	writel_relaxed(0x11800EC, host->ioaddr + CORE_CSR_CDC_CTLR_CFG0);
>  	writel_relaxed(0x3011111, host->ioaddr + CORE_CSR_CDC_CTLR_CFG1);
> 

[toc] | [prev] | [next] | [standalone]


#1569540 — Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-01-30 11:20 +0100
SubjectRe: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence
Message-ID<t5he1-2Kr-1@gated-at.bofh.it>
In reply to#1565724
On 24 January 2017 at 09:50, Ritesh Harjani <riteshh@codeaurora.org> wrote:
> This removes CDC init sequence comments which are
> not useful anyway.
>
> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>

Thanks, applied for next!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-msm.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index b3e8f44..10cdc84 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -664,19 +664,7 @@ static int sdhci_msm_cdclp533_calibration(struct sdhci_host *host)
>         config &= ~CORE_START_CDC_TRAFFIC;
>         writel_relaxed(config, host->ioaddr + CORE_DDR_200_CFG);
>
> -       /*
> -        * Perform CDC Register Initialization Sequence
> -        *
> -        * CORE_CSR_CDC_CTLR_CFG0       0x11800EC
> -        * CORE_CSR_CDC_CTLR_CFG1       0x3011111
> -        * CORE_CSR_CDC_CAL_TIMER_CFG0  0x1201000
> -        * CORE_CSR_CDC_CAL_TIMER_CFG1  0x4
> -        * CORE_CSR_CDC_REFCOUNT_CFG    0xCB732020
> -        * CORE_CSR_CDC_COARSE_CAL_CFG  0xB19
> -        * CORE_CSR_CDC_DELAY_CFG       0x3AC
> -        * CORE_CDC_OFFSET_CFG          0x0
> -        * CORE_CDC_SLAVE_DDA_CFG       0x16334
> -        */
> +       /* Perform CDC Register Initialization Sequence */
>
>         writel_relaxed(0x11800EC, host->ioaddr + CORE_CSR_CDC_CTLR_CFG0);
>         writel_relaxed(0x3011111, host->ioaddr + CORE_CSR_CDC_CTLR_CFG1);
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project.
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web