Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1569486

Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence

From Adrian Hunter <adrian.hunter@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence
Date 2017-01-30 10:20 +0100
Message-ID <t5ghY-2bl-11@gated-at.bofh.it> (permalink)
References <t357l-24T-37@gated-at.bofh.it> <t357l-24T-35@gated-at.bofh.it>
Organization Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw


On 24/01/17 10:50, Ritesh Harjani wrote:
> This removes CDC init sequence comments which are
> not useful anyway.
> 
> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-msm.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index b3e8f44..10cdc84 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -664,19 +664,7 @@ static int sdhci_msm_cdclp533_calibration(struct sdhci_host *host)
>  	config &= ~CORE_START_CDC_TRAFFIC;
>  	writel_relaxed(config, host->ioaddr + CORE_DDR_200_CFG);
>  
> -	/*
> -	 * Perform CDC Register Initialization Sequence
> -	 *
> -	 * CORE_CSR_CDC_CTLR_CFG0	0x11800EC
> -	 * CORE_CSR_CDC_CTLR_CFG1	0x3011111
> -	 * CORE_CSR_CDC_CAL_TIMER_CFG0	0x1201000
> -	 * CORE_CSR_CDC_CAL_TIMER_CFG1	0x4
> -	 * CORE_CSR_CDC_REFCOUNT_CFG	0xCB732020
> -	 * CORE_CSR_CDC_COARSE_CAL_CFG	0xB19
> -	 * CORE_CSR_CDC_DELAY_CFG	0x3AC
> -	 * CORE_CDC_OFFSET_CFG		0x0
> -	 * CORE_CDC_SLAVE_DDA_CFG	0x16334
> -	 */
> +	/* Perform CDC Register Initialization Sequence */
>  
>  	writel_relaxed(0x11800EC, host->ioaddr + CORE_CSR_CDC_CTLR_CFG0);
>  	writel_relaxed(0x3011111, host->ioaddr + CORE_CSR_CDC_CTLR_CFG1);
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC init sequence Ritesh Harjani <riteshh@codeaurora.org> - 2017-01-24 10:00 +0100
  Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC  init sequence Adrian Hunter <adrian.hunter@intel.com> - 2017-01-30 10:20 +0100
  Re: [PATCHv1 2/2] mmc: sdhci-msm: Remove unnecessary comments of CDC  init sequence Ulf Hansson <ulf.hansson@linaro.org> - 2017-01-30 11:20 +0100

csiph-web