Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561339 > unrolled thread

Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy  APIs Peter Chen <hzpeterchen@gmail.com> - 2017-01-18 08:40 +0100
    Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs Stephen Boyd <stephen.boyd@linaro.org> - 2017-01-18 22:00 +0100
      Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs Rob Herring <robh+dt@kernel.org> - 2017-01-18 22:10 +0100
        Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy  APIs Peter Chen <hzpeterchen@gmail.com> - 2017-01-19 07:40 +0100

#1561339 — Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

On Tue, Jan 17, 2017 at 09:58:33AM -0800, Stephen Boyd wrote:
> Quoting Peter Chen (2017-01-15 19:45:51)
> > 
> > So, you need to call phy_set_mode when switching between host and device.
> > Besides, you also need to toggle VBUSVLDEXT when the external vbus
> > is on or off at device mode (doesn't need for host mode), is it correct?
> 
> Correct.
> 
> > 
> > At include/linux/usb/phy.h, we have .set_vbus interface, maybe you need
> > to port it to generic phy framework.
> > 
> 
> Ok. I'll look into that. Can the other patches in this series be picked
> up? Otherwise I can resend them all again once I fix the phy_set_mode()
> call location and introduce a new phy op.

I can pick up chipidea patches after you test the patch I supplied at:

	[PATCH v6 11/25] usb: chipidea: vbus event may exist before starting
gadget

You may ping other maintainers to pick up other patches.

-- 

Best Regards,
Peter Chen

[toc] | [next] | [standalone]

#1562173 — Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

Quoting Peter Chen (2017-01-17 23:34:32)
> On Tue, Jan 17, 2017 at 09:58:33AM -0800, Stephen Boyd wrote:
> > Quoting Peter Chen (2017-01-15 19:45:51)
> > > 
> > > At include/linux/usb/phy.h, we have .set_vbus interface, maybe you need
> > > to port it to generic phy framework.
> > > 
> > 
> > Ok. I'll look into that. Can the other patches in this series be picked
> > up? Otherwise I can resend them all again once I fix the phy_set_mode()
> > call location and introduce a new phy op.
> 
> I can pick up chipidea patches after you test the patch I supplied at:
> 
>         [PATCH v6 11/25] usb: chipidea: vbus event may exist before starting
> gadget

Ok. I've confirmed that this updated patch works fine for me. You can
have my Tested-by and Reviewed-by there.

> 
> You may ping other maintainers to pick up other patches.
> 

I was hoping you could pick the beginning of the series up until the PHY
drivers, which can go via Kishon's tree. That would mean applying the
drivers/of/ part. Rob is that ok?

[toc] | [prev] | [next] | [standalone]

#1562179 — Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

On Wed, Jan 18, 2017 at 2:54 PM, Stephen Boyd <stephen.boyd@linaro.org> wrote:
> Quoting Peter Chen (2017-01-17 23:34:32)
>> On Tue, Jan 17, 2017 at 09:58:33AM -0800, Stephen Boyd wrote:
>> > Quoting Peter Chen (2017-01-15 19:45:51)
>> > >
>> > > At include/linux/usb/phy.h, we have .set_vbus interface, maybe you need
>> > > to port it to generic phy framework.
>> > >
>> >
>> > Ok. I'll look into that. Can the other patches in this series be picked
>> > up? Otherwise I can resend them all again once I fix the phy_set_mode()
>> > call location and introduce a new phy op.
>>
>> I can pick up chipidea patches after you test the patch I supplied at:
>>
>>         [PATCH v6 11/25] usb: chipidea: vbus event may exist before starting
>> gadget
>
> Ok. I've confirmed that this updated patch works fine for me. You can
> have my Tested-by and Reviewed-by there.
>
>>
>> You may ping other maintainers to pick up other patches.
>>
>
> I was hoping you could pick the beginning of the series up until the PHY
> drivers, which can go via Kishon's tree. That would mean applying the
> drivers/of/ part. Rob is that ok?

Peter, If there's a dependency then please take the patches I've
acked. That's why I acked them.

Rob

[toc] | [prev] | [next] | [standalone]

#1562433

On Wed, Jan 18, 2017 at 02:57:27PM -0600, Rob Herring wrote:
> On Wed, Jan 18, 2017 at 2:54 PM, Stephen Boyd <stephen.boyd@linaro.org> wrote:
> > Quoting Peter Chen (2017-01-17 23:34:32)
> >> On Tue, Jan 17, 2017 at 09:58:33AM -0800, Stephen Boyd wrote:
> >> > Quoting Peter Chen (2017-01-15 19:45:51)
> >> > >
> >> > > At include/linux/usb/phy.h, we have .set_vbus interface, maybe you need
> >> > > to port it to generic phy framework.
> >> > >
> >> >
> >> > Ok. I'll look into that. Can the other patches in this series be picked
> >> > up? Otherwise I can resend them all again once I fix the phy_set_mode()
> >> > call location and introduce a new phy op.
> >>
> >> I can pick up chipidea patches after you test the patch I supplied at:
> >>
> >>         [PATCH v6 11/25] usb: chipidea: vbus event may exist before starting
> >> gadget
> >
> > Ok. I've confirmed that this updated patch works fine for me. You can
> > have my Tested-by and Reviewed-by there.
> >
> >>
> >> You may ping other maintainers to pick up other patches.
> >>
> >
> > I was hoping you could pick the beginning of the series up until the PHY
> > drivers, which can go via Kishon's tree. That would mean applying the
> > drivers/of/ part. Rob is that ok?
> 
> Peter, If there's a dependency then please take the patches I've
> acked. That's why I acked them.
> 

Ok, I will do it.

-- 

Best Regards,
Peter Chen

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web