Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs

From	Peter Chen <hzpeterchen@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs
Date	2017-01-18 08:40 +0100
Message-ID	<t0T0C-19o-25@gated-at.bofh.it> (permalink)
References	(5 earlier) <sZ0SB-4cE-3@gated-at.bofh.it> <sZ0SB-4cE-1@gated-at.bofh.it> <t06sW-319-15@gated-at.bofh.it> <t06sW-319-13@gated-at.bofh.it> <t0T0C-19o-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 17, 2017 at 09:58:33AM -0800, Stephen Boyd wrote:
> Quoting Peter Chen (2017-01-15 19:45:51)
> > 
> > So, you need to call phy_set_mode when switching between host and device.
> > Besides, you also need to toggle VBUSVLDEXT when the external vbus
> > is on or off at device mode (doesn't need for host mode), is it correct?
> 
> Correct.
> 
> > 
> > At include/linux/usb/phy.h, we have .set_vbus interface, maybe you need
> > to port it to generic phy framework.
> > 
> 
> Ok. I'll look into that. Can the other patches in this series be picked
> up? Otherwise I can resend them all again once I fix the phy_set_mode()
> call location and introduce a new phy op.

I can pick up chipidea patches after you test the patch I supplied at:

	[PATCH v6 11/25] usb: chipidea: vbus event may exist before starting
gadget

You may ping other maintainers to pick up other patches.

-- 

Best Regards,
Peter Chen

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy  APIs Peter Chen <hzpeterchen@gmail.com> - 2017-01-18 08:40 +0100
  Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs Stephen Boyd <stephen.boyd@linaro.org> - 2017-01-18 22:00 +0100
    Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy APIs Rob Herring <robh+dt@kernel.org> - 2017-01-18 22:10 +0100
      Re: [PATCH v6 23/25] usb: chipidea: Pullup D+ in device mode via phy  APIs Peter Chen <hzpeterchen@gmail.com> - 2017-01-19 07:40 +0100

csiph-web