Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563992 > unrolled thread
| Started by | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| First post | 2017-01-21 00:30 +0100 |
| Last post | 2017-01-23 05:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 00:30 +0100
Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable Rajendra Nayak <rnayak@codeaurora.org> - 2017-01-23 05:10 +0100
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2017-01-21 00:30 +0100 |
| Subject | Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable |
| Message-ID | <t1QN4-5bm-9@gated-at.bofh.it> |
On 01/10, Stanimir Varbanov wrote: > > > + udelay(1); > > + > > + reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr; > > + ret = gdsc_poll_status(sc, reg, 0); > > This should be gdsc_poll_status(sc, reg, true) because after disabling > hw_control we expect that the GDSC is in power_on state. > > > + if (ret) > > + return ret; > > } > > > > if (sc->pwrsts & PWRSTS_OFF) > > I expect this patch is going for v2? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [next] | [standalone]
| From | Rajendra Nayak <rnayak@codeaurora.org> |
|---|---|
| Date | 2017-01-23 05:10 +0100 |
| Subject | Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable |
| Message-ID | <t2E78-1B0-3@gated-at.bofh.it> |
| In reply to | #1563992 |
On 01/21/2017 04:50 AM, Stephen Boyd wrote: > On 01/10, Stanimir Varbanov wrote: >> >>> + udelay(1); >>> + >>> + reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr; >>> + ret = gdsc_poll_status(sc, reg, 0); >> >> This should be gdsc_poll_status(sc, reg, true) because after disabling >> hw_control we expect that the GDSC is in power_on state. >> >>> + if (ret) >>> + return ret; >>> } >>> >>> if (sc->pwrsts & PWRSTS_OFF) >>> > > I expect this patch is going for v2? Yes, sorry, coming up shortly. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web