Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1563992

Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable
Date 2017-01-21 00:30 +0100
Message-ID <t1QN4-5bm-9@gated-at.bofh.it> (permalink)
References <sXXDs-5Ss-7@gated-at.bofh.it> <sY14l-80P-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 01/10, Stanimir Varbanov wrote:
> 
> > +		udelay(1);
> > +
> > +		reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr;
> > +		ret = gdsc_poll_status(sc, reg, 0);
> 
> This should be gdsc_poll_status(sc, reg, true) because after disabling
> hw_control we expect that the GDSC is in power_on state.
> 
> > +		if (ret)
> > +			return ret;
> >  	}
> >  
> >  	if (sc->pwrsts & PWRSTS_OFF)
> > 

I expect this patch is going for v2?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control  enable/disable Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 00:30 +0100
  Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable Rajendra Nayak <rnayak@codeaurora.org> - 2017-01-23 05:10 +0100

csiph-web