Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561965 > unrolled thread

[PATCH 0/3] m68k: Fine-tuning for sys_cacheflush()

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] m68k: Fine-tuning for sys_cacheflush() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 18:00 +0100
    [PATCH 2/3] m68k: Delete an unnecessary variable assignment in  sys_cacheflush() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 18:00 +0100
    [PATCH 1/3] m68k: Return directly after a failed capable() in  sys_cacheflush() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 18:00 +0100

#1561965 — [PATCH 0/3] m68k: Fine-tuning for sys_cacheflush()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Jan 2017 17:42:34 +0100

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (3):
  Return directly after a failed capable()
  Delete an unnecessary variable assignment
  Add some spaces for better code readability

 arch/m68k/kernel/sys_m68k.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1561966 — [PATCH 2/3] m68k: Delete an unnecessary variable assignment in sys_cacheflush()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Jan 2017 17:07:52 +0100

Delete an assignment for the local variable "ret" in an if branch
because it was initialised by the same value.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/m68k/kernel/sys_m68k.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/m68k/kernel/sys_m68k.c b/arch/m68k/kernel/sys_m68k.c
index 62bfeb3716a7..9870d00d2215 100644
--- a/arch/m68k/kernel/sys_m68k.c
+++ b/arch/m68k/kernel/sys_m68k.c
@@ -397,7 +397,6 @@ sys_cacheflush (unsigned long addr, int scope, int cache, unsigned long len)
 		 * Verify that the specified address region actually belongs
 		 * to this process.
 		 */
-		ret = -EINVAL;
 		down_read(&current->mm->mmap_sem);
 		vma = find_vma(current->mm, addr);
 		if (!vma || addr < vma->vm_start || addr + len > vma->vm_end)
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1561969 — [PATCH 1/3] m68k: Return directly after a failed capable() in sys_cacheflush()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Jan 2017 16:30:36 +0100

Return directly after a call of the function "capable" failed
at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/m68k/kernel/sys_m68k.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/m68k/kernel/sys_m68k.c b/arch/m68k/kernel/sys_m68k.c
index 9aa01adb407f..62bfeb3716a7 100644
--- a/arch/m68k/kernel/sys_m68k.c
+++ b/arch/m68k/kernel/sys_m68k.c
@@ -384,9 +384,8 @@ sys_cacheflush (unsigned long addr, int scope, int cache, unsigned long len)
 
 	if (scope == FLUSH_SCOPE_ALL) {
 		/* Only the superuser may explicitly flush the whole cache. */
-		ret = -EPERM;
 		if (!capable(CAP_SYS_ADMIN))
-			goto out;
+			return -EPERM;
 	} else {
 		struct vm_area_struct *vma;
 
-- 
2.11.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web