Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1561969

[PATCH 1/3] m68k: Return directly after a failed capable() in sys_cacheflush()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 1/3] m68k: Return directly after a failed capable() in sys_cacheflush()
Date 2017-01-18 18:00 +0100
Message-ID <t11Ky-6w7-31@gated-at.bofh.it> (permalink)
References <t11Kx-6w7-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Jan 2017 16:30:36 +0100

Return directly after a call of the function "capable" failed
at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/m68k/kernel/sys_m68k.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/m68k/kernel/sys_m68k.c b/arch/m68k/kernel/sys_m68k.c
index 9aa01adb407f..62bfeb3716a7 100644
--- a/arch/m68k/kernel/sys_m68k.c
+++ b/arch/m68k/kernel/sys_m68k.c
@@ -384,9 +384,8 @@ sys_cacheflush (unsigned long addr, int scope, int cache, unsigned long len)
 
 	if (scope == FLUSH_SCOPE_ALL) {
 		/* Only the superuser may explicitly flush the whole cache. */
-		ret = -EPERM;
 		if (!capable(CAP_SYS_ADMIN))
-			goto out;
+			return -EPERM;
 	} else {
 		struct vm_area_struct *vma;
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] m68k: Fine-tuning for sys_cacheflush() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 18:00 +0100
  [PATCH 2/3] m68k: Delete an unnecessary variable assignment in  sys_cacheflush() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 18:00 +0100
  [PATCH 1/3] m68k: Return directly after a failed capable() in  sys_cacheflush() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 18:00 +0100

csiph-web