Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1561372 > unrolled thread

Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int

Started byLinus Walleij <linus.walleij@linaro.org>
First post2017-01-18 10:30 +0100
Last post2017-01-18 10:30 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int Linus Walleij <linus.walleij@linaro.org> - 2017-01-18 10:30 +0100

#1561372 — Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int

FromLinus Walleij <linus.walleij@linaro.org>
Date2017-01-18 10:30 +0100
SubjectRe: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int
Message-ID<t0UJ3-2cD-3@gated-at.bofh.it>
On Fri, Jan 13, 2017 at 2:20 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redudant. Remove the check and the associated
> dev_err error message.
>
> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Fixed up speling & commit topic and applied with
Nishanth's ACK!

Yours,
Linus Walleij

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web