Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1561372
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int |
| Date | 2017-01-18 10:30 +0100 |
| Message-ID | <t0UJ3-2cD-3@gated-at.bofh.it> (permalink) |
| References | <sZa5A-1nw-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 13, 2017 at 2:20 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redudant. Remove the check and the associated
> dev_err error message.
>
> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Fixed up speling & commit topic and applied with
Nishanth's ACK!
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int Linus Walleij <linus.walleij@linaro.org> - 2017-01-18 10:30 +0100
csiph-web