Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560705 > unrolled thread

Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Peter Zijlstra <peterz@infradead.org> - 2017-01-17 16:30 +0100
    Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Shivappa Vikas <vikas.shivappa@intel.com> - 2017-01-17 21:30 +0100

#1560705 — Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare

On Fri, Jan 06, 2017 at 01:59:58PM -0800, Vikas Shivappa wrote:
> - Introduce event_terminate as event_destroy is called after cgrp is
> disassociated from the event to support rmid handling of the cgroup.
> This helps cqm clean up the cqm specific arch_info.

You've not even tried to audit the code to see if you can either move
the existing ->destroy() invocation or the perf_detach_cgroup() one,
have you?

Minimal APIs are a good thing, don't expand unless you absolutely have
to.

[toc] | [next] | [standalone]

#1560990

On Tue, 17 Jan 2017, Peter Zijlstra wrote:

> On Fri, Jan 06, 2017 at 01:59:58PM -0800, Vikas Shivappa wrote:
>> - Introduce event_terminate as event_destroy is called after cgrp is
>> disassociated from the event to support rmid handling of the cgroup.
>> This helps cqm clean up the cqm specific arch_info.
>
> You've not even tried to audit the code to see if you can either move
> the existing ->destroy() invocation or the perf_detach_cgroup() one,
> have you?
>
> Minimal APIs are a good thing, don't expand unless you absolutely have
> to.

yes , the perf_detach_cgroup can just do the job.. Thanks for pointing. Will 
fix.

>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web