Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare

From	Shivappa Vikas <vikas.shivappa@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare
Date	2017-01-17 21:30 +0100
Message-ID	<t0Iye-3cj-17@gated-at.bofh.it> (permalink)
References	<sWKRY-8g7-37@gated-at.bofh.it> <sWLbl-8oT-47@gated-at.bofh.it> <t0DRV-jr-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Tue, 17 Jan 2017, Peter Zijlstra wrote:

> On Fri, Jan 06, 2017 at 01:59:58PM -0800, Vikas Shivappa wrote:
>> - Introduce event_terminate as event_destroy is called after cgrp is
>> disassociated from the event to support rmid handling of the cgroup.
>> This helps cqm clean up the cqm specific arch_info.
>
> You've not even tried to audit the code to see if you can either move
> the existing ->destroy() invocation or the perf_detach_cgroup() one,
> have you?
>
> Minimal APIs are a good thing, don't expand unless you absolutely have
> to.

yes , the perf_detach_cgroup can just do the job.. Thanks for pointing. Will 
fix.

>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Peter Zijlstra <peterz@infradead.org> - 2017-01-17 16:30 +0100
  Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Shivappa Vikas <vikas.shivappa@intel.com> - 2017-01-17 21:30 +0100

csiph-web