Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1556779 > unrolled thread
| Started by | David Lechner <david@lechnology.com> |
|---|---|
| First post | 2017-01-11 19:00 +0100 |
| Last post | 2017-01-16 00:50 +0100 |
| Articles | 7 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] ti,ads7950 device tree bindings David Lechner <david@lechnology.com> - 2017-01-11 19:00 +0100
[PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" David Lechner <david@lechnology.com> - 2017-01-11 19:00 +0100
Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" Jonathan Cameron <jic23@kernel.org> - 2017-01-14 14:00 +0100
Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" David Lechner <david@lechnology.com> - 2017-01-14 19:10 +0100
Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" Jonathan Cameron <jic23@kernel.org> - 2017-01-15 15:00 +0100
Re: [PATCH 0/3] ti,ads7950 device tree bindings Jonathan Cameron <jic23@kernel.org> - 2017-01-15 15:00 +0100
Re: [PATCH 0/3] ti,ads7950 device tree bindings David Lechner <david@lechnology.com> - 2017-01-16 00:50 +0100
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2017-01-11 19:00 +0100 |
| Subject | [PATCH 0/3] ti,ads7950 device tree bindings |
| Message-ID | <sYvlL-1rB-5@gated-at.bofh.it> |
This series adds device tree bindings for the TI ADS7950 family of A/DC chips. The series includes the bindings documentation and some fixes to the iio driver to make it work with the device tree bindings. FYI, the ads7950 driver has not made it into mainline yet, so no worries about breaking anyone with these changes. David Lechner (3): DT/bindings: Add bindings for TI ADS7950 A/DC chips iio: adc: ti-ads7950: Drop "ti-" prefix from module name iio: adc: ti-ads7950: Change regulator matching string to "vref" .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++ drivers/iio/adc/ti-ads7950.c | 32 +++++++++++----------- 2 files changed, 39 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt -- 2.7.4
[toc] | [next] | [standalone]
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2017-01-11 19:00 +0100 |
| Subject | [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" |
| Message-ID | <sYvlM-1rB-59@gated-at.bofh.it> |
| In reply to | #1556779 |
This changes the reference voltage regulator matching string from "refin"
to "vref". This is to be consistent with other A/DC chips that also use
"vref-supply" in their device tree bindings.
Signed-off-by: David Lechner <david@lechnology.com>
---
drivers/iio/adc/ti-ads7950.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
index b587fa6..16a0663 100644
--- a/drivers/iio/adc/ti-ads7950.c
+++ b/drivers/iio/adc/ti-ads7950.c
@@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi)
spi_message_init_with_transfers(&st->scan_single_msg,
st->scan_single_xfer, 3);
- st->reg = devm_regulator_get(&spi->dev, "refin");
+ st->reg = devm_regulator_get(&spi->dev, "vref");
if (IS_ERR(st->reg)) {
- dev_err(&spi->dev, "Failed get get regulator \"refin\"\n");
+ dev_err(&spi->dev, "Failed get get regulator \"vref\"\n");
return PTR_ERR(st->reg);
}
ret = regulator_enable(st->reg);
if (ret) {
- dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n");
+ dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n");
return ret;
}
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-01-14 14:00 +0100 |
| Subject | Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" |
| Message-ID | <sZw65-64k-7@gated-at.bofh.it> |
| In reply to | #1556788 |
On 11/01/17 17:52, David Lechner wrote:
> This changes the reference voltage regulator matching string from "refin"
> to "vref". This is to be consistent with other A/DC chips that also use
> "vref-supply" in their device tree bindings.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
> drivers/iio/adc/ti-ads7950.c | 6 +++---
Again, we missed this before and it would have been nice to have
had it as vref (which is matches the datasheet). The question
becomes how do we handle this going forward with no risk of breaking
existing device trees. We may have to do an optional get on one
name and then a non optional on the second. It's ugly, but
would fix this up in a 'safe' way.
Jonathan
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
> index b587fa6..16a0663 100644
> --- a/drivers/iio/adc/ti-ads7950.c
> +++ b/drivers/iio/adc/ti-ads7950.c
> @@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi)
> spi_message_init_with_transfers(&st->scan_single_msg,
> st->scan_single_xfer, 3);
>
> - st->reg = devm_regulator_get(&spi->dev, "refin");
> + st->reg = devm_regulator_get(&spi->dev, "vref");
> if (IS_ERR(st->reg)) {
> - dev_err(&spi->dev, "Failed get get regulator \"refin\"\n");
> + dev_err(&spi->dev, "Failed get get regulator \"vref\"\n");
> return PTR_ERR(st->reg);
> }
>
> ret = regulator_enable(st->reg);
> if (ret) {
> - dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n");
> + dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n");
> return ret;
> }
>
>
[toc] | [prev] | [next] | [standalone]
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2017-01-14 19:10 +0100 |
| Subject | Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" |
| Message-ID | <sZAW5-H0-9@gated-at.bofh.it> |
| In reply to | #1558981 |
On 01/14/2017 06:52 AM, Jonathan Cameron wrote:
> On 11/01/17 17:52, David Lechner wrote:
>> This changes the reference voltage regulator matching string from "refin"
>> to "vref". This is to be consistent with other A/DC chips that also use
>> "vref-supply" in their device tree bindings.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> ---
>> drivers/iio/adc/ti-ads7950.c | 6 +++---
> Again, we missed this before and it would have been nice to have
> had it as vref (which is matches the datasheet). The question
> becomes how do we handle this going forward with no risk of breaking
> existing device trees. We may have to do an optional get on one
> name and then a non optional on the second. It's ugly, but
> would fix this up in a 'safe' way.
>
Again, I don't think it is too late since this driver only exists in the
iio/testing branch.
> Jonathan
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
>> index b587fa6..16a0663 100644
>> --- a/drivers/iio/adc/ti-ads7950.c
>> +++ b/drivers/iio/adc/ti-ads7950.c
>> @@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi)
>> spi_message_init_with_transfers(&st->scan_single_msg,
>> st->scan_single_xfer, 3);
>>
>> - st->reg = devm_regulator_get(&spi->dev, "refin");
>> + st->reg = devm_regulator_get(&spi->dev, "vref");
>> if (IS_ERR(st->reg)) {
>> - dev_err(&spi->dev, "Failed get get regulator \"refin\"\n");
>> + dev_err(&spi->dev, "Failed get get regulator \"vref\"\n");
>> return PTR_ERR(st->reg);
>> }
>>
>> ret = regulator_enable(st->reg);
>> if (ret) {
>> - dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n");
>> + dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n");
>> return ret;
>> }
>>
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-01-15 15:00 +0100 |
| Subject | Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" |
| Message-ID | <sZTvH-3b6-1@gated-at.bofh.it> |
| In reply to | #1559034 |
On 14/01/17 18:09, David Lechner wrote:
> On 01/14/2017 06:52 AM, Jonathan Cameron wrote:
>> On 11/01/17 17:52, David Lechner wrote:
>>> This changes the reference voltage regulator matching string from "refin"
>>> to "vref". This is to be consistent with other A/DC chips that also use
>>> "vref-supply" in their device tree bindings.
>>>
>>> Signed-off-by: David Lechner <david@lechnology.com>
>>> ---
>>> drivers/iio/adc/ti-ads7950.c | 6 +++---
>> Again, we missed this before and it would have been nice to have
>> had it as vref (which is matches the datasheet). The question
>> becomes how do we handle this going forward with no risk of breaking
>> existing device trees. We may have to do an optional get on one
>> name and then a non optional on the second. It's ugly, but
>> would fix this up in a 'safe' way.
>>
>
> Again, I don't think it is too late since this driver only exists in the iio/testing branch.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
>
>> Jonathan
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
>>> index b587fa6..16a0663 100644
>>> --- a/drivers/iio/adc/ti-ads7950.c
>>> +++ b/drivers/iio/adc/ti-ads7950.c
>>> @@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi)
>>> spi_message_init_with_transfers(&st->scan_single_msg,
>>> st->scan_single_xfer, 3);
>>>
>>> - st->reg = devm_regulator_get(&spi->dev, "refin");
>>> + st->reg = devm_regulator_get(&spi->dev, "vref");
>>> if (IS_ERR(st->reg)) {
>>> - dev_err(&spi->dev, "Failed get get regulator \"refin\"\n");
>>> + dev_err(&spi->dev, "Failed get get regulator \"vref\"\n");
>>> return PTR_ERR(st->reg);
>>> }
>>>
>>> ret = regulator_enable(st->reg);
>>> if (ret) {
>>> - dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n");
>>> + dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n");
>>> return ret;
>>> }
>>>
>>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2017-01-15 15:00 +0100 |
| Message-ID | <sZTvH-3b6-9@gated-at.bofh.it> |
| In reply to | #1556779 |
On 11/01/17 17:52, David Lechner wrote: > This series adds device tree bindings for the TI ADS7950 family of A/DC chips. > The series includes the bindings documentation and some fixes to the iio driver > to make it work with the device tree bindings. > > FYI, the ads7950 driver has not made it into mainline yet, so no worries about > breaking anyone with these changes. > And here's the bit I failed to read! As an extra point, could you confirm what /sys/bus/iio/iio\:deviceX/name for this one reads? I have a feeling this is another case of what Lars has been pointing out in other drivers this morning. That name should be the device part number.. Thanks, Jonathan > David Lechner (3): > DT/bindings: Add bindings for TI ADS7950 A/DC chips > iio: adc: ti-ads7950: Drop "ti-" prefix from module name > iio: adc: ti-ads7950: Change regulator matching string to "vref" > > .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++ > drivers/iio/adc/ti-ads7950.c | 32 +++++++++++----------- > 2 files changed, 39 insertions(+), 16 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >
[toc] | [prev] | [next] | [standalone]
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2017-01-16 00:50 +0100 |
| Message-ID | <t02IF-tJ-5@gated-at.bofh.it> |
| In reply to | #1559238 |
On 01/15/2017 07:58 AM, Jonathan Cameron wrote: > On 11/01/17 17:52, David Lechner wrote: >> This series adds device tree bindings for the TI ADS7950 family of A/DC chips. >> The series includes the bindings documentation and some fixes to the iio driver >> to make it work with the device tree bindings. >> >> FYI, the ads7950 driver has not made it into mainline yet, so no worries about >> breaking anyone with these changes. >> > And here's the bit I failed to read! > > As an extra point, could you confirm what /sys/bus/iio/iio\:deviceX/name for this > one reads? I have a feeling this is another case of what Lars has been pointing > out in other drivers this morning. That name should be the device part number.. > cat /sys/bus/iio/devices/iio\:device0/name ads7957 This is the part number for the specific chip I am using. So, I am guessing that it is correct unless it is supposed to be upper case or something like that. > Thanks, > > Jonathan >> David Lechner (3): >> DT/bindings: Add bindings for TI ADS7950 A/DC chips >> iio: adc: ti-ads7950: Drop "ti-" prefix from module name >> iio: adc: ti-ads7950: Change regulator matching string to "vref" >> >> .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++ >> drivers/iio/adc/ti-ads7950.c | 32 +++++++++++----------- >> 2 files changed, 39 insertions(+), 16 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web