Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559034

Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref"

Show all headers | View raw

On 01/14/2017 06:52 AM, Jonathan Cameron wrote:
> On 11/01/17 17:52, David Lechner wrote:
>> This changes the reference voltage regulator matching string from "refin"
>> to "vref". This is to be consistent with other A/DC chips that also use
>> "vref-supply" in their device tree bindings.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> ---
>>  drivers/iio/adc/ti-ads7950.c | 6 +++---
> Again, we missed this before and it would have been nice to have
> had it as vref (which is matches the datasheet).  The question
> becomes how do we handle this going forward with no risk of breaking
> existing device trees.  We may have to do an optional get on one
> name and then a non optional on the second. It's ugly, but
> would fix this up in a 'safe' way.
>

Again, I don't think it is too late since this driver only exists in the 
iio/testing branch.

> Jonathan
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
>> index b587fa6..16a0663 100644
>> --- a/drivers/iio/adc/ti-ads7950.c
>> +++ b/drivers/iio/adc/ti-ads7950.c
>> @@ -411,15 +411,15 @@ static int ti_ads7950_probe(struct spi_device *spi)
>>  	spi_message_init_with_transfers(&st->scan_single_msg,
>>  					st->scan_single_xfer, 3);
>>
>> -	st->reg = devm_regulator_get(&spi->dev, "refin");
>> +	st->reg = devm_regulator_get(&spi->dev, "vref");
>>  	if (IS_ERR(st->reg)) {
>> -		dev_err(&spi->dev, "Failed get get regulator \"refin\"\n");
>> +		dev_err(&spi->dev, "Failed get get regulator \"vref\"\n");
>>  		return PTR_ERR(st->reg);
>>  	}
>>
>>  	ret = regulator_enable(st->reg);
>>  	if (ret) {
>> -		dev_err(&spi->dev, "Failed to enable regulator \"refin\"\n");
>> +		dev_err(&spi->dev, "Failed to enable regulator \"vref\"\n");
>>  		return ret;
>>  	}
>>
>>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ti,ads7950 device tree bindings David Lechner <david@lechnology.com> - 2017-01-11 19:00 +0100
  [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" David Lechner <david@lechnology.com> - 2017-01-11 19:00 +0100
    Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching  string to "vref" Jonathan Cameron <jic23@kernel.org> - 2017-01-14 14:00 +0100
      Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching  string to "vref" David Lechner <david@lechnology.com> - 2017-01-14 19:10 +0100
        Re: [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching  string to "vref" Jonathan Cameron <jic23@kernel.org> - 2017-01-15 15:00 +0100
  Re: [PATCH 0/3] ti,ads7950 device tree bindings Jonathan Cameron <jic23@kernel.org> - 2017-01-15 15:00 +0100
    Re: [PATCH 0/3] ti,ads7950 device tree bindings David Lechner <david@lechnology.com> - 2017-01-16 00:50 +0100

csiph-web