Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1513001 > unrolled thread
| Started by | Tomas Winkler <tomas.winkler@intel.com> |
|---|---|
| First post | 2016-11-01 01:10 +0100 |
| Last post | 2016-11-04 06:30 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Tomas Winkler <tomas.winkler@intel.com> - 2016-11-01 01:10 +0100
Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-02 11:10 +0100
Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-04 06:30 +0100
| From | Tomas Winkler <tomas.winkler@intel.com> |
|---|---|
| Date | 2016-11-01 01:10 +0100 |
| Subject | [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend |
| Message-ID | <syuOm-155-3@gated-at.bofh.it> |
Place kdoc just above tpm_pcr_extend so it can be parsed
correctly.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/char/tpm/tpm-interface.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index cb0e57ee053d..d496a6b26a45 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -731,6 +731,14 @@ int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf)
}
EXPORT_SYMBOL_GPL(tpm_pcr_read);
+#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
+#define EXTEND_PCR_RESULT_SIZE 34
+static const struct tpm_input_header pcrextend_header = {
+ .tag = TPM_TAG_RQU_COMMAND,
+ .length = cpu_to_be32(34),
+ .ordinal = TPM_ORD_PCR_EXTEND
+};
+
/**
* tpm_pcr_extend - extend pcr value with hash
* @chip_num: tpm idx # or AN&
@@ -741,14 +749,6 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read);
* isn't, protect against the chip disappearing, by incrementing
* the module usage count.
*/
-#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
-#define EXTEND_PCR_RESULT_SIZE 34
-static const struct tpm_input_header pcrextend_header = {
- .tag = TPM_TAG_RQU_COMMAND,
- .length = cpu_to_be32(34),
- .ordinal = TPM_ORD_PCR_EXTEND
-};
-
int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash)
{
struct tpm_cmd_t cmd;
--
2.7.4
[toc] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2016-11-02 11:10 +0100 |
| Subject | Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend |
| Message-ID | <sz0Ey-4RY-7@gated-at.bofh.it> |
| In reply to | #1513001 |
On Tue, Nov 01, 2016 at 03:05:13AM +0200, Tomas Winkler wrote:
> Place kdoc just above tpm_pcr_extend so it can be parsed
> correctly.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpm-interface.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> index cb0e57ee053d..d496a6b26a45 100644
> --- a/drivers/char/tpm/tpm-interface.c
> +++ b/drivers/char/tpm/tpm-interface.c
> @@ -731,6 +731,14 @@ int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf)
> }
> EXPORT_SYMBOL_GPL(tpm_pcr_read);
>
> +#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
> +#define EXTEND_PCR_RESULT_SIZE 34
> +static const struct tpm_input_header pcrextend_header = {
> + .tag = TPM_TAG_RQU_COMMAND,
> + .length = cpu_to_be32(34),
> + .ordinal = TPM_ORD_PCR_EXTEND
> +};
> +
> /**
> * tpm_pcr_extend - extend pcr value with hash
> * @chip_num: tpm idx # or AN&
> @@ -741,14 +749,6 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read);
> * isn't, protect against the chip disappearing, by incrementing
> * the module usage count.
> */
> -#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
> -#define EXTEND_PCR_RESULT_SIZE 34
> -static const struct tpm_input_header pcrextend_header = {
> - .tag = TPM_TAG_RQU_COMMAND,
> - .length = cpu_to_be32(34),
> - .ordinal = TPM_ORD_PCR_EXTEND
> -};
> -
> int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash)
> {
> struct tpm_cmd_t cmd;
> --
> 2.7.4
>
[toc] | [prev] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2016-11-04 06:30 +0100 |
| Subject | Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend |
| Message-ID | <szFeF-5KK-5@gated-at.bofh.it> |
| In reply to | #1513783 |
On Wed, Nov 02, 2016 at 04:02:20AM -0600, Jarkko Sakkinen wrote:
> On Tue, Nov 01, 2016 at 03:05:13AM +0200, Tomas Winkler wrote:
> > Place kdoc just above tpm_pcr_extend so it can be parsed
> > correctly.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
I applied this although I edited the short description (stripped
away "/tpm-interface".
/Jarkko
>
> /Jarkko
>
> > ---
> > drivers/char/tpm/tpm-interface.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> > index cb0e57ee053d..d496a6b26a45 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -731,6 +731,14 @@ int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf)
> > }
> > EXPORT_SYMBOL_GPL(tpm_pcr_read);
> >
> > +#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
> > +#define EXTEND_PCR_RESULT_SIZE 34
> > +static const struct tpm_input_header pcrextend_header = {
> > + .tag = TPM_TAG_RQU_COMMAND,
> > + .length = cpu_to_be32(34),
> > + .ordinal = TPM_ORD_PCR_EXTEND
> > +};
> > +
> > /**
> > * tpm_pcr_extend - extend pcr value with hash
> > * @chip_num: tpm idx # or AN&
> > @@ -741,14 +749,6 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read);
> > * isn't, protect against the chip disappearing, by incrementing
> > * the module usage count.
> > */
> > -#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
> > -#define EXTEND_PCR_RESULT_SIZE 34
> > -static const struct tpm_input_header pcrextend_header = {
> > - .tag = TPM_TAG_RQU_COMMAND,
> > - .length = cpu_to_be32(34),
> > - .ordinal = TPM_ORD_PCR_EXTEND
> > -};
> > -
> > int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash)
> > {
> > struct tpm_cmd_t cmd;
> > --
> > 2.7.4
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web